From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] gst1-plugins-bad: rework license type construction
Date: Sun, 13 May 2018 23:22:19 +0200 [thread overview]
Message-ID: <20180513232219.710f6cd1@windsurf.home> (raw)
In-Reply-To: <1525633443-942-1-git-send-email-danomimanchego123@gmail.com>
Hello,
On Sun, 6 May 2018 15:04:02 -0400, Danomi Manchego wrote:
> Use "GST1_PLUGINS_BAD_LICENSE := $(GST1_PLUGINS_BAD_LICENSE), xxxx" construct
> so that the list of licenses is presented as a comma-separated list.
>
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
I've applied to master, thanks! One comment below though.
> # Add GPL license if GPL licensed plugins enabled.
> ifeq ($(GST1_PLUGINS_BAD_HAS_GPL_LICENSE),y)
> -GST1_PLUGINS_BAD_LICENSE += GPL
> +GST1_PLUGINS_BAD_LICENSE := $(GST1_PLUGINS_BAD_LICENSE), GPL
It would be nice to make this vague "GPL" statement a bit clearer. Are
we talking about GPL-2.0, GPL-2.0+, GPL-3.0, GPL-3.0+ ? Or a
combination of these ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-13 21:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 19:04 [Buildroot] [PATCH 1/2] gst1-plugins-bad: rework license type construction Danomi Manchego
2018-05-06 19:04 ` [Buildroot] [PATCH 2/2] gst1-plugins-bad: update plugin licenses Danomi Manchego
2018-05-13 21:07 ` Yann E. MORIN
2018-05-24 21:02 ` Peter Korsgaard
2018-05-13 21:04 ` [Buildroot] [PATCH 1/2] gst1-plugins-bad: rework license type construction Yann E. MORIN
2018-05-13 21:22 ` Thomas Petazzoni [this message]
2018-05-14 2:01 ` Danomi Manchego
2018-05-14 6:10 ` Thomas Petazzoni
2018-05-24 21:02 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180513232219.710f6cd1@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox