From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gdb: actually disable gdbserver if BR2_PACKAGE_GDB_SERVER is unset
Date: Sat, 19 May 2018 14:17:39 +0200 [thread overview]
Message-ID: <20180519141739.5aed5f2a@windsurf> (raw)
In-Reply-To: <20180515133442.16607-1-anssi.hannula@bitwise.fi>
Hello,
On Tue, 15 May 2018 16:34:42 +0300, Anssi Hannula wrote:
> The gdb configure script is given --enable-gdbserver when
> BR2_PACKAGE_GDB_SERVER is set, but it is not given --disable-gdbserver
> when BR2_PACKAGE_GDB_SERVER is unset.
>
> gdb gdb/configure.ac defaults to enabling gdbserver in "native"
> (host=target) cases, which is always the case when buildroot builds a
> gdb which runs on the target hardware. The gdbserver will overwrite
> BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY gdbserver, if any.
>
> Fix that by passing --disable-gdbserver when BR2_PACKAGE_GDB_SERVER is
> unset.
>
> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
> ---
> package/gdb/gdb.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Good catch. Applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-19 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 13:34 [Buildroot] [PATCH] gdb: actually disable gdbserver if BR2_PACKAGE_GDB_SERVER is unset Anssi Hannula
2018-05-19 12:17 ` Thomas Petazzoni [this message]
2018-06-11 21:11 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180519141739.5aed5f2a@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox