From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] protobuf, python-protobuf: bump to v3.5.1
Date: Mon, 21 May 2018 09:49:59 +0200 [thread overview]
Message-ID: <20180521094959.64e1a59f@windsurf> (raw)
In-Reply-To: <20180521050550.11898-1-charles.hardin@storagecraft.com>
Hello,
On Sun, 20 May 2018 22:05:47 -0700, charles.hardin at storagecraft.com
wrote:
> From: Charles Hardin <charles.hardin@storagecraft.com>
>
> Also, add a patch to compile for mips big endian
> in addition to mips little endian.
>
> Signed-off-by: Charles Hardin <charles.hardin@storagecraft.com>
This bump is already in the next branch:
https://git.buildroot.org/buildroot/commit/?h=next&id=454aa2da5e79ec8627f1d66ac640ec7bb04025dc.
> diff --git a/package/protobuf/0001-convert-mipsel-to-mips.patch b/package/protobuf/0001-convert-mipsel-to-mips.patch
> new file mode 100644
> index 0000000000..005d818d9d
> --- /dev/null
> +++ b/package/protobuf/0001-convert-mipsel-to-mips.patch
> @@ -0,0 +1,12 @@
> +diff -Naur protobuf-3.5.1.orig/src/google/protobuf/stubs/platform_macros.h protobuf-3.5.1/src/google/protobuf/stubs/platform_macros.h
> +--- protobuf-3.5.1.orig/src/google/protobuf/stubs/platform_macros.h 2017-12-20 23:07:13.000000000 +0000
> ++++ protobuf-3.5.1/src/google/protobuf/stubs/platform_macros.h 2018-05-21 03:46:58.580000399 +0000
> +@@ -56,7 +56,7 @@
> + #elif defined(__aarch64__)
> + #define GOOGLE_PROTOBUF_ARCH_AARCH64 1
> + #define GOOGLE_PROTOBUF_ARCH_64_BIT 1
> +-#elif defined(__MIPSEL__)
> ++#elif defined(__mips__)
> + #if defined(__LP64__)
> + #define GOOGLE_PROTOBUF_ARCH_MIPS64 1
> + #define GOOGLE_PROTOBUF_ARCH_64_BIT 1
All patches require a description and Signed-off-by. Since upstream
uses Git as its version control system, the patch should be generated
using "git format-patch".
> # When bumping this package, make sure to also verify if the
> # python-protobuf package still works, as they share the same
> # version/site variables.
While doing the bump, you missed this comment. No a big deal since the
bump has already been done, but I thought I should point this out.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-05-21 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 5:05 [Buildroot] [PATCH 1/4] protobuf, python-protobuf: bump to v3.5.1 charles.hardin at storagecraft.com
2018-05-21 5:05 ` [Buildroot] [PATCH 2/4] package/c-ares: enable the host variant for a c-ares install charles.hardin at storagecraft.com
2018-05-21 5:05 ` [Buildroot] [PATCH 3/4] grpc: new package charles.hardin at storagecraft.com
2018-05-21 7:58 ` Thomas Petazzoni
2018-05-21 16:12 ` Charles Hardin
2018-05-21 5:05 ` [Buildroot] [PATCH 4/4] package/collectd: allow the grpc plugin to be configured charles.hardin at storagecraft.com
2018-05-21 8:00 ` Thomas Petazzoni
2018-05-21 5:35 ` [Buildroot] [PATCH 1/4] protobuf, python-protobuf: bump to v3.5.1 Baruch Siach
2018-05-21 5:51 ` Charles Hardin
2018-05-21 6:02 ` Baruch Siach
2018-05-21 6:13 ` Charles Hardin
2018-05-21 7:49 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521094959.64e1a59f@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox