From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH-NEXT 2/2] chrony: S49chrony: drop /etc/chrony.conf check
Date: Mon, 28 May 2018 17:21:58 +0200 [thread overview]
Message-ID: <20180528172158.6828b1bf@windsurf.home> (raw)
In-Reply-To: <20180528132258.13860-2-peter@korsgaard.com>
Hello,
On Mon, 28 May 2018 15:22:58 +0200, Peter Korsgaard wrote:
> With CHRONY_ARGS in /etc/default/chrony, chrony may asked to use an
> alternative configuration file (with the -f option), so drop the explicit
> /etc/chrony.conf check.
>
> In case the configuration file isn't present chrony will anyway loudly
> complain which is preferable to this silent failure:
>
> chronyd -f /non/existing/file.conf
> Could not open configuration file /non/existing/file.conf : No such file or directory
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
I really hate those stupid checks, they cause more harm than good. So
it's great to remove those checks.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-28 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 13:22 [Buildroot] [PATCH-NEXT 1/2] chrony: S49chrony: support a defaults file Peter Korsgaard
2018-05-28 13:22 ` [Buildroot] [PATCH-NEXT 2/2] chrony: S49chrony: drop /etc/chrony.conf check Peter Korsgaard
2018-05-28 15:21 ` Thomas Petazzoni [this message]
2018-05-28 18:21 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528172158.6828b1bf@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox