From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Mon, 28 May 2018 22:45:01 +0200 Subject: [Buildroot] [PATCH 6/8] ti-sgx-km: rename options to have proper prefix In-Reply-To: <4299684e-6356-dcf3-a35d-9fb9ef6606bb@mind.be> References: <20180513190737.26079-1-thomas.petazzoni@bootlin.com> <20180513190737.26079-7-thomas.petazzoni@bootlin.com> <20180513193140.GJ22130@scaer> <20180516090052.21e0af47@windsurf> <87wovwiuai.fsf@dell.be.48ers.dk> <4299684e-6356-dcf3-a35d-9fb9ef6606bb@mind.be> Message-ID: <20180528204501.GL2965@scaer> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout, Peter, All, On 2018-05-22 12:42 +0200, Arnout Vandecappelle spake thusly: > On 21-05-18 23:16, Peter Korsgaard wrote: > >>>>>> "Arnout" == Arnout Vandecappelle writes: > > > > > On 16-05-18 09:00, Thomas Petazzoni wrote: > > >> Hello, > > >> > > >> On Tue, 15 May 2018 23:52:33 +0200, Arnout Vandecappelle wrote: > > >> > > >>>> What is nice with this solution, is that we have the new choice that is > > >>>> right near the legacy option so we can chek it, and it automatically > > >>>> gets the old setting. > > >>>> > > >>>> But I am not too convinced, however, because we do not usually use the > > >>>> name of a choice elsewhere... > > >>> > > >>> Legacy is pretty special anyway. I do think it's worthwhile it to do this properly. > > >> > > >> Is this an Acked-by to the approach this patch series has taken in > > >> terms of handling the Config.in choice option renaming ? > > > > > Er, no, it's a NACK. I *do* think it's worthwhile to properly select the new > > > option. Yeah, but as we've gone without support for legacy choices so far (almost 6 years now), I don't think this is an urgent matter. Next time, maybe I'll just shut up instead of suggesting sophisticated and imaginative solutions. ;-P Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'