From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/2] shadowsocks-libev: bump to version 3.2.0 add a patch for libipset licence add hashes for the license files Fix shadowsocks-libev.mk
Date: Sun, 3 Jun 2018 20:37:35 +0200 [thread overview]
Message-ID: <20180603203735.6b123022@windsurf> (raw)
In-Reply-To: <20180530221315.19012-2-xuminready@gmail.com>
Hello!
Thanks for this contribution!
On Wed, 30 May 2018 15:13:14 -0700, Min Xu wrote:
> Signed-off-by: Min Xu <xuminready@gmail.com>
> ---
> .../0001-docs-add-BSD-3-Clause-licence.patch | 52 ++++++++++++++++++++++
> package/shadowsocks-libev/shadowsocks-libev.hash | 8 +++-
> package/shadowsocks-libev/shadowsocks-libev.mk | 9 ++--
> 3 files changed, 63 insertions(+), 6 deletions(-)
> create mode 100644 package/shadowsocks-libev/0001-docs-add-BSD-3-Clause-licence.patch
All those changes should be part of the patch adding the
shadowsocks-libev package. If you're not familiar with Git, then look
at using "git rebase --interactive", it allows you to rewrite the
commit history.
In your case, you would have to do:
$ git rebase --interactive HEAD~2
This opens up your text editor, with two lines, one for each of your
two commits. On the second line, change the "pick" word for "fixup",
and exit your text editor.
This will rewrite the two commits by merging the second one into the
first one.
> diff --git a/package/shadowsocks-libev/0001-docs-add-BSD-3-Clause-licence.patch b/package/shadowsocks-libev/0001-docs-add-BSD-3-Clause-licence.patch
> new file mode 100644
> index 0000000..64dda02
> --- /dev/null
> +++ b/package/shadowsocks-libev/0001-docs-add-BSD-3-Clause-licence.patch
> @@ -0,0 +1,52 @@
> +From 0047295445c499e010706598c50f1bff8b0d632c Mon Sep 17 00:00:00 2001
> +From: Min Xu <xuminready@gmail.com>
> +Date: Wed, 30 May 2018 13:16:12 -0700
> +Subject: [PATCH] docs: add BSD-3-Clause licence
> +
> +add missing licence for shadowsocks-libev/libipset
> +
> +Signed-off-by: Min Xu <xuminready@gmail.com>
I'm not sure it makes a lot of sense to add a patch adding the license
file, especially if the patch is not blessed by upstream.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-06-03 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 22:13 [Buildroot] [PATCH v3 1/2] shadowsocks-libev: new package Min Xu
2018-05-30 22:13 ` [Buildroot] [PATCH v3 2/2] shadowsocks-libev: bump to version 3.2.0 add a patch for libipset licence add hashes for the license files Fix shadowsocks-libev.mk Min Xu
2018-06-03 18:37 ` Thomas Petazzoni [this message]
2018-06-04 7:30 ` xu min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180603203735.6b123022@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox