From: Gary Bisson <gary.bisson@boundarydevices.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] weston: add weston-imx variant when using imx-gpu-viv
Date: Mon, 4 Jun 2018 11:52:35 +0200 [thread overview]
Message-ID: <20180604095235.GA25676@g751.home> (raw)
In-Reply-To: <a461da37-e484-57b9-be4d-f91ffbea9cae@mind.be>
Hi Arnout
On Thu, May 17, 2018 at 11:19:18PM +0200, Arnout Vandecappelle wrote:
>
>
> On 17-05-18 15:08, Gary Bisson wrote:
> > Hi Arnout,
> >
> > On Wed, May 16, 2018 at 11:24:17PM +0200, Arnout Vandecappelle wrote:
> >>
> >>
> >> On 16-05-18 17:52, Gary Bisson wrote:
> [snip]
> >>> +ifeq ($(BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_WL),y)
> >>> +ifeq ($(BR2_PACKAGE_IMX_GPU_G2D),y)
> >>
> >> WESTON_CONF_OPTS += --enable-imxg2d
> >
> > Ok, I forgot you wanted that --enable-xxx options to be explicit
> > although it ends up in the 'unrecognized options'.
>
> So I took a look at the configure.ac, and of course they got it wrong;
> --enable-imxg2d will disable it. So your patch was correct.
>
> Reading documentation is apparently difficult :-)
Haha, thanks for checking.
> Since I'm not entirely convinced of the config option myself anyway:
>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Thomas, I've seen you applied the rest of the series, do you have any
objection about that patch?
Regards,
Gary
next prev parent reply other threads:[~2018-06-04 9:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 15:51 [Buildroot] [PATCH 0/3] imx: add Wayland GPU libs / Weston-imx support Gary Bisson
2018-05-16 15:51 ` [Buildroot] [PATCH 1/3] imx-gpu-viv: add Wayland backend option Gary Bisson
2018-05-19 20:06 ` Thomas Petazzoni
2018-05-16 15:52 ` [Buildroot] [PATCH 2/3] weston: remove dependency on mesa3d to enable egl Gary Bisson
2018-05-19 20:46 ` Thomas Petazzoni
2018-05-16 15:52 ` [Buildroot] [PATCH 3/3] weston: add weston-imx variant when using imx-gpu-viv Gary Bisson
2018-05-16 21:24 ` Arnout Vandecappelle
2018-05-17 13:08 ` Gary Bisson
2018-05-17 21:19 ` Arnout Vandecappelle
2018-06-04 9:52 ` Gary Bisson [this message]
2018-06-04 10:05 ` Thomas Petazzoni
2019-02-06 16:42 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604095235.GA25676@g751.home \
--to=gary.bisson@boundarydevices.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox