Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] linux: may fail to boot for binutils 2.29+ even without armv7m
Date: Tue, 5 Jun 2018 07:49:32 +0200	[thread overview]
Message-ID: <20180605074932.668ae4e7@windsurf> (raw)
In-Reply-To: <b3672758-0d2b-51cd-7eac-cc06158a995b@mind.be>

Hello,

On Tue, 5 Jun 2018 00:10:30 +0200, Arnout Vandecappelle wrote:

> >  comment "Linux kernel may fail to boot with binutils >= 2.29"
> > -	depends on BR2_ARM_CPU_ARMV7M
> > +	depends on BR2_arm || BR2_armeb  
> 
>  I have a bit of a problem with this patch. IMO it's rather unlikely that people
> build the kernel in THUMB mode on non-M CPUs.

Are you sure ? There is definitely support for building a Thumb2 kernel
on ARMv7-A, and I think it's a popular way to reduce a bit the size of
the kernel, no?

> But now we're always showing this
> warning. I think it will confuse a number of people, and I don't think it's very
> likely that it will actually help anyone.

Actually the warning should not have a:

	depends on BR2_arm || BR2_armeb

but instead a:

	depends on BR2_ARM_INSTRUCTIONS_THUMB || BR2_ARM_INSTRUCTIONS_THUMB2

because that's actually what we do in binutils to decide whether we
want to fall back on binutils 2.28 by default or not.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-06-05  5:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 18:01 [Buildroot] [PATCHv2] linux: may fail to boot for binutils 2.29+ even without armv7m Yann E. MORIN
2018-06-01 19:42 ` Peter Korsgaard
2018-06-04 22:10 ` Arnout Vandecappelle
2018-06-05  5:49   ` Thomas Petazzoni [this message]
2018-06-05  7:23     ` Laurent GONZALEZ
2018-06-05 15:43       ` Yann E. MORIN
2018-06-05 15:29     ` Yann E. MORIN
2018-06-08 14:22       ` Peter Korsgaard
2018-06-08 17:15         ` Yann E. MORIN
2018-06-05 15:25   ` Yann E. MORIN
2018-06-08 14:19   ` Peter Korsgaard
2018-06-17 15:04 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180605074932.668ae4e7@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox