From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Use one call to mkdir to create needed directories.
Date: Tue, 5 Jun 2018 15:06:41 +0200 [thread overview]
Message-ID: <20180605150641.439f4352@windsurf> (raw)
In-Reply-To: <20180605123611.21759-1-F.LaRoche@pilz.de>
Hello,
On Tue, 5 Jun 2018 14:36:11 +0200, Florian La Roche wrote:
> Reduce this to only call mkdir once to create the needed directories.
>
>
> Signed-off-by: Florian La Roche <F.LaRoche@pilz.de>
Thanks for all your patches. Generally they look good to me in terms of
contents, but there are a few minor formatting issues that would make
them better:
- The commit title should include a prefix of the package being
impacted.
- The commit title should often be a bit shorter.
- The commit log should contain only one empty line before the SoB
line, not two empty lines.
- A non empty commit log would be better, to give additional
explanations when necessary.
For this patch, a better commit log would for example be:
busybox: reduce number of mkdir calls in inittab
The default Busybox inittab does two separate mkdir calls to
create /dev/pts and /dev/shm, which is not necessary. Let's refactor
those two calls into a single one.
Signed-off-by: ...
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-06-05 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 12:36 [Buildroot] [PATCH 1/1] Use one call to mkdir to create needed directories Florian La Roche
2018-06-05 13:06 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605150641.439f4352@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox