From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 7 Jun 2018 18:02:50 +0200 Subject: [Buildroot] [PATCH 1/2] host-cargo: select host-rustc In-Reply-To: <20180606202501.14535-1-fontaine.fabrice@gmail.com> References: <20180606202501.14535-1-fontaine.fabrice@gmail.com> Message-ID: <20180607180250.0df17b2f@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Wed, 6 Jun 2018 22:25:00 +0200, Fabrice Fontaine wrote: > Buildroot documentation specifies that cargo-based package should only > depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS and selects > BR2_PACKAGE_HOST_CARGO but this does not work as host-cargo depends on > BR2_PACKAGE_HAS_HOST_RUSTC which is selected only when host-rustc is > selected. What "does not work" exactly ? Yes, you end up with host-rust being built as a dependency of host-cargo, while BR2_PACKAGE_HOST_RUST is not enabled. But for host packages, we currently don't enforce that their Config.in.host option is enabled when the package is built. So, which problem have you encountered ? I agree that your patch makes sense (it's better to have the Config.in.host option enabled when the corresponding host package is going to be built), but I don't see where the *problem* is, so I'd like to understand before applying. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com