From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] adding-packages-cargo.txt: remove host-cargo select
Date: Sun, 10 Jun 2018 15:01:15 +0200 [thread overview]
Message-ID: <20180610150115.07ed9688@windsurf> (raw)
In-Reply-To: <20180607180327.12308-1-fontaine.fabrice@gmail.com>
Hello,
On Thu, 7 Jun 2018 20:03:27 +0200, Fabrice Fontaine wrote:
> Remove select BR2_PACKAGE_HOST_CARGO from Config.in
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
In fact, I don't agree with this change. Cargo packages are going to
use host-cargo, so it makes sense for them to select.
Today, it is not mandatory for a host package to be selected at the
Config.in level to have it built, and we don't enforce this. But it is
actually more logical to do it, and in line with our long-term idea of
having Config.in options for all host packages.
So, in fact I prefer your original patch, and I disagree with Baruch
statement that we shouldn't do the select. Yes, it is not /needed/, but
it is more correct with the select.
Best regards,
Thoms
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-06-10 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 18:03 [Buildroot] [PATCH 1/1] adding-packages-cargo.txt: remove host-cargo select Fabrice Fontaine
2018-06-10 13:01 ` Thomas Petazzoni [this message]
2018-06-10 13:24 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180610150115.07ed9688@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox