Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] support/testing: fix python syntax
Date: Sun, 10 Jun 2018 15:57:27 +0200	[thread overview]
Message-ID: <20180610155727.4de7c16f@windsurf> (raw)
In-Reply-To: <2ae621feecea77223421234eaef0de7032c841d1.1528016895.git.yann.morin.1998@free.fr>

Hello,

On Sun,  3 Jun 2018 11:08:21 +0200, Yann E. MORIN wrote:
> Fix three issues with code style in our test infra:
>   - 'print' is now a function,
>   - exceptions need to be caught-assigned with the 'as' keyword,
>   - old-style "%s"%() formatting is deprecated.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> 
> ---
> Changes v1 -> v2:
>   - this was previously caught because of a spurious switch to
>     python3-flake8, as noticed by Ricardo. We're now back to using
>     python-flake8, so the rationale has changed. Still, we do want
>     to fix those because it makes sense anyway.
> ---
>  support/testing/infra/__init__.py |  6 +++---
>  support/testing/infra/basetest.py |  4 ++--
>  support/testing/run-tests         | 26 +++++++++++++-------------
>  3 files changed, 18 insertions(+), 18 deletions(-)

I've dropped the changes that added indices to format strings (since
they would only be needed for Python 2.6 compatibility, and I'm not
sure that it's a worthwhile goal to be able to run the test suite on
Python 2.6 machines). And then I've applied to master. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-06-10 13:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-03  9:08 [Buildroot] [PATCH 0/5] support/docker: make the image more reproducible Yann E. MORIN
2018-06-03  9:08 ` [Buildroot] [PATCH 1/5] support/docker: run apt-get update and apt-get install in two RUNs Yann E. MORIN
2018-06-03 18:31   ` Thomas Petazzoni
2018-06-03  9:08 ` [Buildroot] [PATCH 2/5] support/docker: sort the list of installed packages Yann E. MORIN
2018-06-03 23:21   ` Ricardo Martincoski
2018-06-04 16:11     ` Yann E. MORIN
2018-06-03  9:08 ` [Buildroot] [PATCH 3/5] support/docker: use the distro-provided flake8 Yann E. MORIN
2018-06-05  2:12   ` Ricardo Martincoski
2018-06-03  9:08 ` [Buildroot] [PATCH 4/5] support/testing: fix python syntax Yann E. MORIN
2018-06-05  2:17   ` Ricardo Martincoski
2018-06-05  5:51     ` Thomas Petazzoni
2018-06-10 13:57   ` Thomas Petazzoni [this message]
2018-06-03  9:08 ` [Buildroot] [PATCH 5/5] support/docker: update to python3-flavoured flake8 Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180610155727.4de7c16f@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox