From: "Gaël PORTAY" <gael.portay@savoirfairelinux.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] fix qtwebengine enable condition
Date: Mon, 11 Jun 2018 10:57:44 -0400 [thread overview]
Message-ID: <20180611145744.2s667vhfspxgv34g@archlinux> (raw)
In-Reply-To: <20180607134528.7098-1-david.barbion@ext.leroymerlin.fr>
David,
On Thu, Jun 07, 2018 at 03:45:28PM +0200, David Barbion wrote:
> Signed-off-by: David Barbion <david.barbion@ext.leroymerlin.fr>
> ---
> package/qt5/qt5webengine/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/qt5/qt5webengine/Config.in b/package/qt5/qt5webengine/Config.in
> index 38486c6dcf..744d659567 100644
> --- a/package/qt5/qt5webengine/Config.in
> +++ b/package/qt5/qt5webengine/Config.in
> @@ -31,7 +31,7 @@ config BR2_PACKAGE_QT5WEBENGINE
> depends on BR2_TOOLCHAIN_USES_GLIBC # execinfo.h, mallinfo
> depends on BR2_HOST_GCC_AT_LEAST_4_8 # qt5base-icu
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # qt5base-icu
> - depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || BR2_PACKAGE_QT5_VERSION_5_6 # libnss
> + depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || BR2_PACKAGE_QT5_VERSION_5_6 # libnss
Good catch.
> depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, libvpx, qt5base-dbus
> depends on BR2_USE_WCHAR # libglib2
> depends on BR2_PACKAGE_QT5_GL_AVAILABLE # qt5declarative, qt5base-eglfs
> --
> 2.17.1
Do you mind to reword the first line of your commit message to start
with the name of the affected package and a colon?
Something like:
qt5webengine: fix...
Regards,
Gael
next prev parent reply other threads:[~2018-06-11 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 13:45 [Buildroot] [PATCH 1/1] fix qtwebengine enable condition David Barbion
2018-06-07 16:26 ` Matthew Weber
2018-06-11 14:57 ` Gaël PORTAY [this message]
2018-06-12 6:04 ` David Barbion
2018-06-13 20:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611145744.2s667vhfspxgv34g@archlinux \
--to=gael.portay@savoirfairelinux.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox