From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] libusb: add an option to compile examples
Date: Sun, 17 Jun 2018 15:13:45 +0200 [thread overview]
Message-ID: <20180617151345.3034ad05@windsurf> (raw)
In-Reply-To: <20180611134750.27627-1-gael.portay@savoirfairelinux.com>
Hello,
On Mon, 11 Jun 2018 09:47:50 -0400, Ga?l PORTAY wrote:
> +ifeq ($(BR2_PACKAGE_LIBUSB_EXAMPLES),y)
> +LIBUSB_CONF_OPTS += --enable-examples-build
> +define LIBUSB_INSTALL_TARGET_EXAMPLES
> + for example in listdevs xusb fxload hotplugtest testlibusb dpfp dpfp_threaded sam3u_benchmark ; do \
As I said in a review of an earlier version, you should use a make loop
instead of a shell loop. One benefit of make loops is that they bail
out if one iteration of the loop fails. A shell loop doesn't, and
continues with the next iterations.
> + cp -dpfr $(@D)/examples/$${example} $(TARGET_DIR)/usr/bin; \
This should have use $(INSTALL) -D -m 0755 and a full destination path.
I've fixed both issues and applied.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-06-17 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 13:47 [Buildroot] [PATCH v3] libusb: add an option to compile examples Gaël PORTAY
2018-06-17 13:13 ` Thomas Petazzoni [this message]
2018-06-17 21:14 ` Gaël PORTAY
2018-06-17 21:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180617151345.3034ad05@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox