Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Python Tornado bumped to version 5.0.2
Date: Sun, 24 Jun 2018 16:10:43 +0200	[thread overview]
Message-ID: <20180624161043.18941c1a@windsurf> (raw)
In-Reply-To: <20180613142816.19691-1-polygon@wh2.tu-dresden.de>

Hello,

Thanks for your contribution. I've applied, after fixing a few things.
See below for details.

First, the commit title should follow the format:

	<package>: <description>

i.e:

	python-tornado: bump to version 5.0.2

(Notice that we don't use a past tense, but present tense. Indeed the
commit has not bumped to version 5.0.2, the commit is the thing bumping
to 5.0.2)

On Wed, 13 Jun 2018 16:28:16 +0200, Jan Dohl wrote:
> Tornado got a requirement on the SSL module in version 5.0.2
> which is also checked in the setup.py script before installing.
> Since the check in buildroot runs against the host-python which
> is built without SSL support, these checks fail.
> 
> In my opinion, adding OpenSSL support to host-python does not make

We generally try to avoid first person formulations such as "In my
opinion".

> sense since the Python on the target will be a different one. Instead,
> remove the checks (which, according to the source code comments
> essentially check for Python >= 2.7.9 / Python3 >= 3.4 which is
> true for current Buildroot) and select the SSL option of
> Python/Python3 when Tornado is selected.
> 
> Signed-off-by: Jan Dohl <polygon@wh2.tu-dresden.de>

> diff --git a/package/python-tornado/0001-remove-ssl-checks-on-install.patch b/package/python-tornado/0001-remove-ssl-checks-on-install.patch
> new file mode 100644
> index 0000000000..9bf858bbaa
> --- /dev/null
> +++ b/package/python-tornado/0001-remove-ssl-checks-on-install.patch
> @@ -0,0 +1,28 @@
> +diff -Naur python-tornado-5.0.2-orig/setup.py python-tornado-5.0.2/setup.py
> +--- python-tornado-5.0.2-orig/setup.py	2018-04-08 02:31:24.000000000 +0200
> ++++ python-tornado-5.0.2/setup.py	2018-06-13 13:27:50.990071928 +0200
> +@@ -15,7 +15,6 @@

Patches should have a description and Signed-off-by, and should be
Git-formatted if the upstream project uses Git (which is the case here).

I've fixed those issues and applied.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-06-24 14:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 14:28 [Buildroot] [PATCH 1/1] Python Tornado bumped to version 5.0.2 Jan Dohl
2018-06-24 14:10 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180624161043.18941c1a@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox