Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH v5 1/6] at-spi2-core: new package
Date: Mon, 25 Jun 2018 23:09:44 +0200	[thread overview]
Message-ID: <20180625230944.5a3ca2c3@windsurf.home> (raw)
In-Reply-To: <20180622003340.10859-2-joseph.kogut@gmail.com>

Hello,

On Thu, 21 Jun 2018 17:33:35 -0700, Joseph Kogut wrote:
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>

I've applied your patch, after doing a few additional fixes. See below.

> diff --git a/package/at-spi2-core/Config.in b/package/at-spi2-core/Config.in
> new file mode 100644
> index 0000000000..43110e0bf4
> --- /dev/null
> +++ b/package/at-spi2-core/Config.in
> @@ -0,0 +1,24 @@
> +config BR2_PACKAGE_AT_SPI2_CORE
> +	bool "at-spi2-core"
> +	depends on BR2_PACKAGE_XORG7 # xlib-libxtst
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2
> +	depends on BR2_USE_MMU # glib2
> +	depends on BR2_USE_WCHAR # glib2
> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_XLIB_LIBXTST
> +	help
> +	  The At-Spi2 Core package is a part of the GNOME
> +	  Accessibility Project. It provides a Service Provider
> +	  Interface for the Assistive Technologies available on the
> +	  GNOME platform and a library against which applications
> +	  can be linked.
> +
> +	  https://wiki.gnome.org/Accessibility
> +
> +comment "at-spi2-core needs a toolchain w/ wchar, threads"
> +	depends on BR2_USE_MMU
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> +
> +comment "at-spi2-core depends on X.org"

I've added:

	depends on BR2_USE_MMU

here, so that the comment doesn't show up on noMMU architectures where
at-spi2-core will anyway not be available regardless of X.org
availability.

> +	depends on !BR2_PACKAGE_XORG7

> +AT_SPI2_CORE_VERSION_MAJOR = 2.28
> +AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0
> +AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz
> +AT_SPI2_CORE_SITE = http://ftp.gnome.org/pub/gnome/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR)
> +AT_SPI2_CORE_LICENSE = LGPL-2.0+
> +AT_SPI2_CORE_LICENSE_FILES = COPYING
> +AT_SPI2_CORE_INSTALL_STAGING = YES
> +AT_SPI2_CORE_DEPENDENCIES = host-meson host-pkgconf dbus libglib2 xlib_libXtst

Having host-meson in the DEPENDENCIES variable is useless, because the
meson-package infrastructure takes care of that.

Also, I had to specify -Ddbus_daemon=/usr/bin/dbus-daemon, otherwise it
tries to search for the dbus-daemon program on the host machine, and
errors out if it cannot find it.

Applied with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-06-25 21:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22  0:33 [Buildroot] [RFC PATCH v5 0/6] chromium: new package Joseph Kogut
2018-06-22  0:33 ` [Buildroot] [RFC PATCH v5 1/6] at-spi2-core: " Joseph Kogut
2018-06-25 21:09   ` Thomas Petazzoni [this message]
2018-06-25 21:20     ` Joseph Kogut
2018-06-22  0:33 ` [Buildroot] [RFC PATCH v5 2/6] at-spi2-atk: " Joseph Kogut
2018-06-25 21:10   ` Thomas Petazzoni
2018-06-25 21:18     ` Joseph Kogut
2018-06-22  0:33 ` [Buildroot] [RFC PATCH v5 3/6] libgtk3: convert atk-bridge to optional dependency Joseph Kogut
2018-06-22  0:33 ` [Buildroot] [RFC PATCH v5 4/6] llvm: add config to build backend for host arch Joseph Kogut
2018-06-22 10:09   ` Valentin Korenblit
2018-06-22  0:33 ` [Buildroot] [RFC PATCH v5 5/6] lld: new package Joseph Kogut
2018-06-22  0:33 ` [Buildroot] [RFC PATCH v5 6/6] chromium: " Joseph Kogut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180625230944.5a3ca2c3@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox