From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] replace invocation of tempfile w/ mktemp in try-run
Date: Sat, 30 Jun 2018 00:19:07 +0200 [thread overview]
Message-ID: <20180629221907.GA1969@scaer> (raw)
In-Reply-To: <20180629214012.26644-1-joseph.kogut@gmail.com>
Joseph, All,
On 2018-06-29 14:40 -0700, Joseph Kogut spake thusly:
> mktemp is included in GNU Coreutils, and its usage is preferred over
> tempfile.
>
> http://lists.gnu.org/archive/html/bug-coreutils/2007-10/msg00134.html
>
> Additionally, some distributions no longer package tempfile, and
> this patch fixes try-run in that case.
See also cmmit 91a08ecc998 (package/Makefile.in: add host-cc-option
macro) which introduced that initial code, explcitly to add -no-pie when
needed.
> Fixes:
> http://autobuild.buildroot.net/results/db5/db50f4415d18441f94b641ef6dc5a3672678b8b9/
> http://autobuild.buildroot.net/results/76d/76d73f767d3aab3c97d61188f5666899d72ed82d/
> http://autobuild.buildroot.net/results/6aa/6aa9031962603354086b49bc49add92fde496ec2/
> http://autobuild.buildroot.net/results/33d/33d22f4d96fb439be8551355290896ef6d3649df/
> http://autobuild.buildroot.net/results/eee/eeec2ed80e147c172ec2d50958b12cfa38b2cc8d/
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/Makefile.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index a268016cdf..f2962767cc 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -239,7 +239,7 @@ HOST_LDFLAGS += -L$(HOST_DIR)/lib -Wl,-rpath,$(HOST_DIR)/lib
> # Exit code chooses option. "$$TMP" is can be used as temporary file and
> # is automatically cleaned up.
> try-run = $(shell set -e; \
> - TMP="$$(tempfile)"; \
> + TMP="$$(mktemp)"; \
> if ($(1)) >/dev/null 2>&1; \
> then echo "$(2)"; \
> else echo "$(3)"; \
> --
> 2.18.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-06-29 22:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 21:40 [Buildroot] [PATCH 1/1] replace invocation of tempfile w/ mktemp in try-run Joseph Kogut
2018-06-29 22:19 ` Yann E. MORIN [this message]
2018-06-30 16:23 ` Thomas Petazzoni
2018-07-19 9:57 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629221907.GA1969@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox