From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] network-manager: sync kernel headers comment with actual dependency
Date: Sun, 1 Jul 2018 10:54:04 +0200 [thread overview]
Message-ID: <20180701085404.GA2381@scaer> (raw)
In-Reply-To: <20180630221915.448-1-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2018-07-01 00:19 +0200, Thomas Petazzoni spake thusly:
> In commit 52282828f06dc8aa3f721727f68a5096b9ed8b49
> ("package/network-manager: add patches to build with kernel headers
> 3.2"), network-manager was changed to build with kernel headers as old
> as 3.2, instead of 3.7 before. The dependency was changed accordingly,
> but the Config.in comment was not.
>
> This commit fixes this inconsistency.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/network-manager/Config.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in
> index 9602cc4a1a..ca508185f0 100644
> --- a/package/network-manager/Config.in
> +++ b/package/network-manager/Config.in
> @@ -64,8 +64,8 @@ config BR2_PACKAGE_NETWORK_MANAGER_OVS
>
> endif
>
> -comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.7, dynamic library"
> +comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.2, dynamic library"
> depends on BR2_USE_MMU
> depends on !BR2_PACKAGE_HAS_UDEV || \
> - !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 || \
> + !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 || \
> !BR2_TOOLCHAIN_USES_GLIBC || BR2_STATIC_LIBS
> --
> 2.14.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-07-01 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 22:19 [Buildroot] [PATCH] network-manager: sync kernel headers comment with actual dependency Thomas Petazzoni
2018-07-01 8:54 ` Yann E. MORIN [this message]
2018-07-01 9:03 ` Thomas Petazzoni
2018-07-01 20:01 ` Petr Vorel
2018-07-19 10:09 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180701085404.GA2381@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox