From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] pkg-generic: fix no-check-hash for inferred site method
Date: Sat, 14 Jul 2018 23:25:20 +0200 [thread overview]
Message-ID: <20180714232520.50bbc5e6@windsurf> (raw)
In-Reply-To: <20180629014246.13574-1-ricardo.martincoski@gmail.com>
Hello,
On Thu, 28 Jun 2018 22:42:46 -0300, Ricardo Martincoski wrote:
> Currently, when the site method is explicitly set to a SCM other than
> git, the main download is correctly excluded from being hash-checked.
> But when the site method is inferred from the site uri, the download
> from a SCM other than git is wrongly being hash-checked.
>
> Fix this by moving the code that excludes SCM methods from hash-check
> below the code that infers the site method.
>
> Currently there is no package in the tree that uses inferred site
> method, and that is why the autobuilder didn't caught this. We had
> packages using inferred site method in the past, the last one was
> 'expect', but since they didn't have a hash file (for a license or
> extra-download for example) the build didn't error out.
>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
> Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
> Changes v1 -> v2:
> - improve commit message (Luca Ceresoli);
> - collect Reviewed-by & Tested-by tags.
> ---
> package/pkg-generic.mk | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-14 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 1:41 [Buildroot] [PATCH 1/1] pkg-generic: fix no-check-hash for inferred site method Ricardo Martincoski
2018-06-25 21:01 ` Luca Ceresoli
2018-06-26 2:01 ` Ricardo Martincoski
2018-06-26 7:13 ` Luca Ceresoli
2018-06-29 1:42 ` [Buildroot] [PATCH v2 " Ricardo Martincoski
2018-06-29 17:54 ` Yann E. MORIN
2018-07-14 21:25 ` Thomas Petazzoni [this message]
2018-07-19 21:35 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180714232520.50bbc5e6@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox