From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 18 Jul 2018 14:51:46 +0200 Subject: [Buildroot] [PATCH v2 2/2] configs/imx7d-sdb: Add new defconfig In-Reply-To: References: <1531084579-7949-1-git-send-email-festevam@gmail.com> <1531084579-7949-2-git-send-email-festevam@gmail.com> <20180718120128.2454a930@windsurf> Message-ID: <20180718145146.10793a31@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Wed, 18 Jul 2018 09:21:39 -0300, Fabio Estevam wrote: > > However, I find the naming a bit strange. If I understand correctly > > freescale_imx7dsabresd_defconfig and imx7d-sdb_defconfig are for the > > same board, the former using the vendor kernel, the latter using the > > mainline kernel. If that's the case, why isn't the defconfig having the > > same name, except for the freescale_ prefix ? > > For boards that use mainline kernel and U-Boot I try to name its > Buildroot defconfig using the same convention used in its device tree: > -, so that is why I used imx7d-sdb_defconfig. That makes sense. So I guess the DT name in the vendor kernel is different, and that's why our defconfigs have a different name between the vendor and mainline variants for a given board ? > > Also, the board folder is named "imx7dsdb", which isn't very consistent. > > Yes, I can change it to "imx7d-sdb" for better consistency. Yeah, that's just a minor detail :-) However, it still wouldn't be very consistent with the name of the defconfig for the vendor u-boot/kernel variant. Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com