From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gary Bisson <gary.bisson@boundarydevices.com>
Date: Thu, 19 Jul 2018 10:00:54 +0200
Subject: [Buildroot] [PATCH 1/5] board/freescale/common/imx: make
 imx8-bootloader-prepare more generic
In-Reply-To: <20180719094527.6275cd12@windsurf>
References: <20180719073253.22433-1-gary.bisson@boundarydevices.com>
 <20180719073253.22433-2-gary.bisson@boundarydevices.com>
 <20180719094527.6275cd12@windsurf>
Message-ID: <20180719080023.GA23715@g751.home>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hi Thomas,

On Thu, Jul 19, 2018 at 09:45:27AM +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Thu, 19 Jul 2018 09:32:49 +0200, Gary Bisson wrote:
> > Allow user to override the hardcoded dtb name by using
> > BR2_ROOTFS_POST_SCRIPT_ARGS.
> > 
> > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> > ---
> >  .../freescale/common/imx/imx8-bootloader-prepare.sh  | 12 ++++++++++--
> >  1 file changed, 10 insertions(+), 2 deletions(-)
> > 
> > diff --git a/board/freescale/common/imx/imx8-bootloader-prepare.sh b/board/freescale/common/imx/imx8-bootloader-prepare.sh
> > index 2648147ab0..ce2c3405a0 100755
> > --- a/board/freescale/common/imx/imx8-bootloader-prepare.sh
> > +++ b/board/freescale/common/imx/imx8-bootloader-prepare.sh
> > @@ -2,9 +2,17 @@
> >  
> >  main ()
> >  {
> > -	# Currently we support imx8mqevk.
> > +	if [ $# -le 1 ]; then
> > +		UBOOT_DTB=${BINARIES_DIR}/fsl-imx8mq-evk.dtb
> 
> I don't think it's worth keeping some kind of "backward compatibility"
> here. Just change configs/freescale_imx8mqevk_defconfig to pass the DTB
> name as argument.

Fair enough, I'm fine with that. However, should I keep the check on the
arguments number to throw an error if no argument is provided?

Or is the check on UBOOT_DTB existence sufficient?

I'll wait for a day before respinning the series to see if there are
other comments.

Also, not related to the patch, the series doesn't appear "properly" in
the mailing list archive, patches aren't answers to the cover letter.
Other strange thing in Patchwork, patch 4/5 is part of "Untitled series
#56383" instead of the real series, is it normal?
I just want to make sure I'm not missing some settings in my
git-send-email config although it just seems that the server
received/treated the emails in the wrong order.

Regards,
Gary