Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] patch: fix wrong sysroot path when given rsdk toolchain
Date: Thu, 19 Jul 2018 15:32:40 +0200	[thread overview]
Message-ID: <20180719153240.25e67cd9@windsurf> (raw)
In-Reply-To: <14A4BC6FC7AB3340A49D24D6ACB7BED930620C@RS-MBS02.realsil.com.cn>

Hello Shawn,

Thanks for your patch, and for contributing to Buildroot!

On Thu, 19 Jul 2018 09:10:03 +0000, ??? wrote:

> The attachment is a patch that fixes a Realtek toolchain that has a
> sysroot path of ?mips-linux-uclibc?, this causes the buildroot
> recognizes the sysroot as ?mips-linux-uc? by the sed operation, and
> then the external toolchain setup is failed. Adding a ?/? in the sed
> re expression avoids the wrong substitution, other toolchains like
> linaro arm toolchain are tested ok to ensure no side effect is
> induced, please help review and apply this patch, thanks.

Would it be possible to get access to this Realtek toolchain? I'd like
to check the behavior, and understand a bit more the issue, because it
looks a bit suspicious/strange.

The sed expression is supposed to replace:

  /path/to/sysroot/usr/lib/libc.a

by:

  /path/to/sysroot/

So I don't quite see how the ending "libc" in mips-linux-uclibc can
affect this.

Also, for your next patches, could you send them with the patch
description in the commit log (currently your commit log is just
"IPCSDK-6460", which is not very useful) ? Also, they should be sent
with "git send-email", so that the patch is inline.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-07-19 13:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19  9:10 [Buildroot] patch: fix wrong sysroot path when given rsdk toolchain 陈小刚
2018-07-19 13:32 ` Thomas Petazzoni [this message]
2018-07-20  8:21   ` [Buildroot] 答复: " 陈小刚
2018-07-22 21:24     ` Arnout Vandecappelle
2018-07-23  6:54       ` [Buildroot] 答复: " 陈小刚
2019-08-01  8:21         ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719153240.25e67cd9@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox