From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ghostscript: not compiled to use freetype lib
Date: Wed, 25 Jul 2018 16:36:12 +0200 [thread overview]
Message-ID: <20180725163612.7ccaef8e@windsurf> (raw)
In-Reply-To: <1532524091103-0.post@n4.nabble.com>
Hello,
Thanks for your contribution!
On Wed, 25 Jul 2018 08:08:11 -0500 (CDT), Thomas Ehrhardt wrote:
> With this patch ghostscript 9.23 use the freetype lib.
Your patch (and the previous one) lacks a Signed-off-by.
> +ifeq ($(BR2_PACKAGE_FREETYPE),y)
> +GHOSTSCRIPT_DEPENDENCIES += host-freetype
This is most likely incorrect. BR2_PACKAGE_FREETYPE indicates that the
target freetype is available, it has nothing to do with whether
host-freetype should be used or not.
> +HOST_CXXFLAGS += -I$(HOST_DIR)/usr/include/freetype2
This line is incorrect, because it changes the CXXFLAGS globally, for
all packages.
> file package/ghostscript/0002-Fix-shared-lib-freetype.patch
Weird how this is formatted. In any case, all patches should have a
description and Signed-off-by line.
Could you explain what you are trying to achieve ?
> Sent from: http://buildroot-busybox.2317881.n4.nabble.com/
Please send your e-mails to the mailing list directly. If you don't
want to subscribe because of the traffic, then please subscribe and
disable mail delivery in the Mailman preferences. This will allow you
to send e-mails to the list, but you won't receive all the mailing list
traffic.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-25 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 13:08 [Buildroot] [PATCH] ghostscript: not compiled to use freetype lib Thomas Ehrhardt
2018-07-25 14:36 ` Thomas Petazzoni [this message]
2018-07-26 12:51 ` Thomas Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725163612.7ccaef8e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox