Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 3] host-acl: build fix on RHEL6 hosts (GCC 4.4.7)
Date: Thu, 26 Jul 2018 09:43:34 +0200	[thread overview]
Message-ID: <20180726094334.4da615cf@windsurf> (raw)
In-Reply-To: <a5beffd9-7db4-1836-ba1e-a301a2ac90c6@mentor.com>

Hello Hollis,

On Wed, 25 Jul 2018 15:10:56 -0700, Hollis Blanchard wrote:

> >> +Signed-off-by: Hollis Blanchard <hollis_blanchard@mentor.com>  
> > Are you sure removing this won't break the build with newer gcc
> > versions ?  
> I've built it with host gcc 6.3.0 and 4.4.7 and saw no warnings in 
> either case. (Aside: patchelf refused to build with 6.3.0, so I had to 
> manually build that.)
> 
> If some toolchain emits a warning on this code, and if the package is 
> built with -Werror somehow, I suppose it's possible to break the build. 

The package doesn't seem to be built with -Werror by default, so it
should be fine. Let's apply your patch, and see if it works fine on the
autobuilders.

> > However, a larger question is: do you intend to contribute an
> > autobuilder that tests Buildroot under RHEL6 ? Indeed, you are fixing
> > just the few packages that are useful to you, but if we are going to
> > support something as old as RHEL6, then we need to do it properly and
> > have an autobuilder running on this distro. Do you think this is
> > something that could be done ?  
> Not certain, but possible. What does it entail, exactly? Do I just have 
> to run 
> https://git.buildroot.net/buildroot-test/tree/scripts/autobuild-run via 
> cron?

It is about running this script yes, but it does not need to be run in
cron, the script itself is an infinite loop that continuously does some
builds and contribute the results to autobuild.buildroot.org.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-07-26  7:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 17:20 [Buildroot] [PATCH 1 of 3] host-acl: build fix on RHEL6 hosts (GCC 4.4.7) Hollis Blanchard
2018-07-19 17:20 ` [Buildroot] [PATCH 2 of 3] host-attr: build fix for " Hollis Blanchard
2018-07-19 17:20 ` [Buildroot] [PATCH 3 of 3] libglib2: " Hollis Blanchard
2018-07-25 21:12 ` [Buildroot] [PATCH 1 of 3] host-acl: build fix on " Thomas Petazzoni
2018-07-25 22:10   ` Hollis Blanchard
2018-07-26  7:43     ` Thomas Petazzoni [this message]
2018-07-26  7:55       ` Arnout Vandecappelle
2018-07-27 19:30       ` [Buildroot] RHEL6 autobuilder Hollis Blanchard
2018-07-30 12:28         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180726094334.4da615cf@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox