From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Fri, 27 Jul 2018 23:49:30 +0200 Subject: [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added In-Reply-To: References: <20180608062231.2345-1-dde@innovaphone.com> <20180727093114.4943db9a@windsurf> <99413edb-b83b-6d16-327b-192bbf4c09be@mind.be> Message-ID: <20180727234930.3a42d30c@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Fri, 27 Jul 2018 17:39:57 -0400, Adam Duskett wrote: > Another nitpick I would have is that there should probably be a > Config.in entry for this as well. No, probably not. As a general rule in Buildroot, we prefer automatic handling of optional dependencies, in order to avoid a proliferation of gazillion of Config.in options. In addition, postgresql.mk already handles all its optional dependencies this way. The only reason to not do this in this case would be if the XML2 support in postgresql increases significantly the size of the postgresql binary. But again, in general, automatic handling of optional dependencies is preferred. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com