From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 3/3] uboot: zynqmp: allow to use custom psu_init files
Date: Sat, 28 Jul 2018 19:39:52 +0200 [thread overview]
Message-ID: <20180728193952.7094d45b@windsurf> (raw)
In-Reply-To: <20180725143538.25268-4-luca@lucaceresoli.net>
Hello,
On Wed, 25 Jul 2018 16:35:38 +0200, Luca Ceresoli wrote:
> +config BR2_TARGET_UBOOT_ZYNQMP_PSU_INIT_FILE
> + string "Custom psu_init_gpl file"
> + depends on BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
> + help
> + On ZynqMP the booloader is responsible for some basic
> + initializations, such as enabling peripherals and
> + configuring pinmuxes. The psu_init_gpl.c file (and,
> + optionally, psu_init_gpl.h) contains the code for such
> + initializations.
> +
> + Although U-Boot contains psu_init_gpl.c files for some
> + boards, each of them describes only one specific
> + configuration. Users of a different board, or needing a
> + different configuration, can generate custom files using the
> + Xilinx development tools.
> +
> + Set this variable to the path to your psu_init_gpl.c file
> + (e.g. "board/myboard/psu_init_gpl.c"). psu_init_gpl.h, if
> + needed, should be in the same directory. U-Boot will build
> + and link the user-provided file instead of the built-in one.
> +
> + Leave empty to use the files provided by U-Boot.
I've also added a comment here that explains which U-Boot upstream
commit is necessary for this feature to work.
> +UBOOT_ZYNQMP_PSU_INIT = $(call qstrip,$(BR2_TARGET_UBOOT_ZYNQMP_PSU_INIT_FILE))
> +
> +ifneq ($(UBOOT_ZYNQMP_PSU_INIT),)
> +define UBOOT_ZYNQMP_KCONFIG_PSU_INIT
> + $(call KCONFIG_SET_OPT,CONFIG_XILINX_PS_INIT_FILE,"$(shell readlink -f $(UBOOT_ZYNQMP_PSU_INIT))", \
> + $(@D)/.config)
> +endef
> +endif
To be "consistent" with what I did for the PMU firmware, I introduced
an intermediate UBOOT_ZYNQMP_PSU_INIT_PATH variable.
Applied with those changes. Please don't hesitate to verify the
resulting commits to make sure I didn't screw up anything.
Thanks for this work on ZynqMP!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-28 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 14:35 [Buildroot] [PATCH v5 0/3] Add Xilinx ZynqMP and ZCU106 board support Luca Ceresoli
2018-07-25 14:35 ` [Buildroot] [PATCH v5 1/3] uboot: zynqmp: generate SPL image with PMUFW binary Luca Ceresoli
2018-07-26 20:04 ` Joel Carlson
2018-07-28 17:37 ` Thomas Petazzoni
2018-07-28 22:36 ` Luca Ceresoli
2018-07-25 14:35 ` [Buildroot] [PATCH v5 2/3] configs/zynqmp_zcu106_defconfig: add Xilinx ZCU106 board (ZynqMP SoC) Luca Ceresoli
2018-07-26 20:14 ` Joel Carlson
2018-07-28 17:38 ` Thomas Petazzoni
2018-07-25 14:35 ` [Buildroot] [PATCH v5 3/3] uboot: zynqmp: allow to use custom psu_init files Luca Ceresoli
2018-07-26 20:12 ` Joel Carlson
2018-07-28 17:39 ` Thomas Petazzoni [this message]
2018-08-21 9:09 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180728193952.7094d45b@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox