Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/gcc: add support for gcc 8.1
Date: Mon, 30 Jul 2018 15:09:41 +0200	[thread overview]
Message-ID: <20180730150941.2baf8b50@windsurf> (raw)
In-Reply-To: <a3f603da-9f1f-12ee-01cf-d9ef0509ad26@mind.be>

Hello,

On Thu, 24 May 2018 00:08:56 +0200, Arnout Vandecappelle wrote:

> > 0002-arm-softfloat-libgcc.patch was added in 2007 [1] for gcc 4.1.2.
> > I believe arm soft-float should work out of the box now.  
> 
>  The patch refers to https://sourceware.org/ml/crossgcc/2008-05/msg00009.html
> which says "Unfortuantely, arm-gcc defaults to generating code for armv5t."
> Since we always explicitly pass the target CPU for ARM, the default CPU
> shouldn't matter. So, again, a runtime qemu-user test for arm920t would confirm
> that the patch isn't needed.
> 
> 
>  If both patches are indeed unneeded, I'd only remove them for GCC 8, not the
> earlier ones. They're not really hurting the earlier versions at the moment.
> 
>  By the way, I think patch 0003 can also be removed. We only need it because we
> exclude the testsuite in the extraction, to save 252MB of disk space (reducing
> the build directory size from 850 to 600MB). I don't think it's worthwhile
> carrying a patch just for that. Also, since GCC 7, the libjava directory no
> longer exists. So I'd just eliminate that HOST_GCC_EXCLUDES. Thomas, you added
> this feature back in 00e9b1e4f7, what do you think?

No strong feeling about it. It's still 250 MB of saved disk space, and
also the time of extraction (doubled, once for gcc-initial, once for
gcc-final). Back then, I was on a quest trying to reduce the build
time, and this was part of it. There is obviously a trade off between
efficiency and ease of maintenance here, and whether those tweaks are
useful enough to warrant the additional maintenance burden, I don't
know.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-07-30 13:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-05 10:58 [Buildroot] [PATCH] package/gcc: add support for gcc 8.1 Romain Naour
2018-05-20 10:45 ` Thomas Petazzoni
2018-05-21 15:45   ` Romain Naour
2018-05-21 16:42     ` Romain Naour
2018-05-23 22:08       ` Arnout Vandecappelle
2018-07-30 13:09         ` Thomas Petazzoni [this message]
2018-05-21 21:52     ` Peter Korsgaard
2018-05-22  7:02       ` Thomas Petazzoni
2018-05-22  7:18       ` daggs
2018-05-22  7:46         ` Peter Korsgaard
2018-05-22  8:16         ` Thomas Petazzoni
2018-05-22 22:08       ` Arnout Vandecappelle
2018-05-23 20:19         ` Romain Naour
2018-05-23 21:34           ` Arnout Vandecappelle
2018-05-22  7:13     ` daggs
2018-05-23  8:29     ` Thomas Petazzoni
2018-05-23 20:23       ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180730150941.2baf8b50@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox