From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Date: Mon, 30 Jul 2018 23:50:01 +0200
Subject: [Buildroot] [PATCH 2/2] package/opencv3: fix aarch64 build
In-Reply-To: <20180730160836.21016-2-bernd.kuhls@t-online.de>
References: <20180730160836.21016-1-bernd.kuhls@t-online.de>
 <20180730160836.21016-2-bernd.kuhls@t-online.de>
Message-ID: <20180730235001.429c059e@windsurf>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hello,

On Mon, 30 Jul 2018 18:08:36 +0200, Bernd Kuhls wrote:
> https://git.buildroot.net/buildroot/commit/package/opencv3?id=a17402e42d8c996af239cfdb536e74188d6c6245
> 
> enabled CMake option ENABLE_VFPV3 in OpenCV3 for all aarch64 CPUs
> because for them BR2_ARM_CPU_HAS_VFPV3 is always true:
> 
> BR2_ARM_CPU_HAS_FP_ARMV8 selects BR2_ARM_CPU_HAS_VFPV4 which in turn
> selects BR2_ARM_CPU_HAS_VFPV3.
> 
> OpenCV3 however supports vfpv3 only on !aarch64:
> https://github.com/opencv/opencv/blob/3.4/cmake/OpenCVCompilerOptimizations.cmake#L275
> 
> Fixes
> http://autobuild.buildroot.net/results/d38/d38fb092cffe086f93b469d1181da77fba0994bd/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

So this fix is already needed with the currently packaged 3.3.0 version
of OpenCV ?

If so, why is this fix patch coming *after* the version bump in the
series ?

Both 2018.05.x and 2018.02.x are using 3.3.0, so I guess they are
affected as well. However, this failure doesn't appear for 2018.02.x
and 2018.05.x in http://autobuild.buildroot.net/?reason=opencv3% 

Do you have an explanation for this ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com