Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/3] host-attr: build fix for GCC <4.5
Date: Tue, 31 Jul 2018 21:47:23 +0200	[thread overview]
Message-ID: <20180731214723.3071cfca@windsurf> (raw)
In-Reply-To: <20180730220218.26454-2-hollis_blanchard@mentor.com>

Hello,

On Mon, 30 Jul 2018 15:02:17 -0700, Hollis Blanchard wrote:
> Signed-off-by: Hollis Blanchard <hollis_blanchard@mentor.com>

An empty commit log is not very good. Also, in the commit title, use
just "attr" and not "host-attr" as the prefix.

> diff --git a/package/attr/0001-build-with-older-GCCs.patch b/package/attr/0001-build-with-older-GCCs.patch
> new file mode 100644
> index 0000000000..2aa41107f9
> --- /dev/null
> +++ b/package/attr/0001-build-with-older-GCCs.patch
> @@ -0,0 +1,87 @@
> +From 3ac428794ea0f95c854166c9c0cffb0267c5e98b Mon Sep 17 00:00:00 2001
> +From: Hollis Blanchard <hollis_blanchard@mentor.com>
> +Date: Mon, 30 Jul 2018 14:17:21 -0700
> +Subject: [PATCH] build with older GCCs

This is not a good title for a patch. We want the title to say what
the patch does instead.

> +
> +GCC versions up through 4.4.7 (which is used in RHEL 6) do not accept any
> +argument for the deprecated attribute. GCC 4.5 and later say the "msg"
> +argument is optional. We don't need the messages during Buildroot builds
> +anyways.
> +
> +Signed-off-by: Hollis Blanchard <hollis_blanchard@mentor.com>

I fixed up those minor issues and applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-07-31 19:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 22:02 [Buildroot] [PATCH v2 1/3] libglib2: backport upstream patch to handle missing fcntl() flags Hollis Blanchard
2018-07-30 22:02 ` [Buildroot] [PATCH v2 2/3] host-attr: build fix for GCC <4.5 Hollis Blanchard
2018-07-31 19:47   ` Thomas Petazzoni [this message]
2018-07-30 22:02 ` [Buildroot] [PATCH v2 3/3] host-acl: build fix for GCC 4.4.7 Hollis Blanchard
2018-07-31 19:50   ` Thomas Petazzoni
2018-07-31 19:43 ` [Buildroot] [PATCH v2 1/3] libglib2: backport upstream patch to handle missing fcntl() flags Thomas Petazzoni
2018-08-20 20:32 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180731214723.3071cfca@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox