From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/opencv3: fix aarch64 build
Date: Tue, 31 Jul 2018 22:08:22 +0200 [thread overview]
Message-ID: <20180731220822.20cb6921@windsurf> (raw)
In-Reply-To: <20180730160836.21016-2-bernd.kuhls@t-online.de>
Hello,
On Mon, 30 Jul 2018 18:08:36 +0200, Bernd Kuhls wrote:
> https://git.buildroot.net/buildroot/commit/package/opencv3?id=a17402e42d8c996af239cfdb536e74188d6c6245
>
> enabled CMake option ENABLE_VFPV3 in OpenCV3 for all aarch64 CPUs
> because for them BR2_ARM_CPU_HAS_VFPV3 is always true:
>
> BR2_ARM_CPU_HAS_FP_ARMV8 selects BR2_ARM_CPU_HAS_VFPV4 which in turn
> selects BR2_ARM_CPU_HAS_VFPV3.
>
> OpenCV3 however supports vfpv3 only on !aarch64:
> https://github.com/opencv/opencv/blob/3.4/cmake/OpenCVCompilerOptimizations.cmake#L275
>
> Fixes
> http://autobuild.buildroot.net/results/d38/d38fb092cffe086f93b469d1181da77fba0994bd/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/opencv3/opencv3.mk | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Applied to master with an improved commit log. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-31 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 16:08 [Buildroot] [PATCH 1/2] package/opencv3: bump version to 3.4.2 Bernd Kuhls
2018-07-30 16:08 ` [Buildroot] [PATCH 2/2] package/opencv3: fix aarch64 build Bernd Kuhls
2018-07-30 21:50 ` Thomas Petazzoni
2018-07-31 5:19 ` Bernd Kuhls
2018-07-31 20:08 ` Thomas Petazzoni
2018-07-31 20:08 ` Thomas Petazzoni [this message]
2018-07-31 20:09 ` [Buildroot] [PATCH 1/2] package/opencv3: bump version to 3.4.2 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731220822.20cb6921@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox