Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David De Grave (Essensium/Mind) <david.degrave@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] boot/uboot: missing dtc build dependency
Date: Wed,  1 Aug 2018 16:33:36 +0200	[thread overview]
Message-ID: <20180801143336.25420-1-david.degrave@mind.be> (raw)

When trying to include multiple DTBs in a FIT image for u-boot, the
device tree compiler (dtc) is not build as expected and fails with the
following error:

  DTC     arch/arm/dts/foo.dtb
/bin/sh: ./scripts/dtc/dtc: No such file or directory
make[4]: *** [scripts/Makefile.lib:329: arch/arm/dts/foo.dtb] Error 127

Using host-dtc instead leads to more problems than it solves and is
kept to support older versions of u-boot where dtc support were not
provided.

So better to keep using the U-Boot provided dtc and add a patch to fix
this issue by adding a dependency on OF_CONTROL for OF_LIST and
by selecting DTC for MULTI_DTB_FIT in dts/Kconfig.

Signed-off-by: David De Grave (Essensium/Mind) <david.degrave@mind.be>

---
 v2: Add patch to fix the dependencies in Kconfig as noticed by Arnout
 v1: Tried to use HOST_DTC
---
 .../0001-missing-dtc-dependency-in-kconfig.patch      | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 boot/uboot/2018.01/0001-missing-dtc-dependency-in-kconfig.patch

diff --git a/boot/uboot/2018.01/0001-missing-dtc-dependency-in-kconfig.patch b/boot/uboot/2018.01/0001-missing-dtc-dependency-in-kconfig.patch
new file mode 100644
index 0000000000..28ebf50185
--- /dev/null
+++ b/boot/uboot/2018.01/0001-missing-dtc-dependency-in-kconfig.patch
@@ -0,0 +1,19 @@
+diff -ru a/dts/Kconfig b/dts/Kconfig
+--- a/dts/Kconfig	2018-01-09 02:25:29.000000000 +0100
++++ b/dts/Kconfig	2018-08-01 15:35:57.676153869 +0200
+@@ -113,6 +113,7 @@
+ 
+ config OF_LIST
+ 	string "List of device tree files to include for DT control"
++	depends on OF_CONTROL
+ 	depends on SPL_LOAD_FIT || MULTI_DTB_FIT
+ 	default DEFAULT_DEVICE_TREE
+ 	help
+@@ -135,6 +136,7 @@
+ 
+ config MULTI_DTB_FIT
+ 	bool "Support embedding several DTBs in a FIT image for u-boot"
++	select DTC
+ 	help
+ 	  This option provides hooks to allow U-boot to parse an
+ 	  appended FIT image and enable board specific code to then select
-- 
2.13.6

             reply	other threads:[~2018-08-01 14:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 14:33 David De Grave [this message]
2018-08-02  7:30 ` [Buildroot] [PATCH v2 1/1] boot/uboot: missing dtc build dependency Thomas Petazzoni
2018-08-02 10:45 ` Arnout Vandecappelle
2018-08-02 11:49   ` David De Grave

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801143336.25420-1-david.degrave@mind.be \
    --to=david.degrave@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox