From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/qt5/qt5base: fix PKG_CONFIG_LIBDIR
Date: Sun, 5 Aug 2018 12:55:39 +0200 [thread overview]
Message-ID: <20180805125539.7bff50c7@windsurf> (raw)
In-Reply-To: <20180802180944.26935-1-bernd.kuhls@t-online.de>
Hello,
On Thu, 2 Aug 2018 20:09:44 +0200, Bernd Kuhls wrote:
> By default pkgconf searches "${libdir}/pkgconfig:${datadir}/pkgconfig"
> for .pc files:
> https://github.com/pkgconf/pkgconf/blob/844f0a66621629a65e3cbf3c3ca47185602e9df5/configure.ac#L41
>
> The new xorgproto package installs .pc files to ${datadir}/pkgconfig
> whichs translates to $(STAGING_DIR)/usr/share/pkgconfig, for example
> dri3proto:
> https://cgit.freedesktop.org/xorg/proto/xorgproto/tree/Makefile.am#n65
>
> whereas the old xproto_ packages installed their .pc files to
> ${libdir}/pkgconfig:
> https://cgit.freedesktop.org/xorg/proto/dri3proto/tree/Makefile.am?id=3937f72040b79c7245b261da880364177cc40a6e#n4
>
> Normally this upstream change is not a problem because pkgconf searches
> both paths for .pc files, unless we define PKG_CONFIG_LIBDIR with
> something else like we did for the last six years ;)
> https://github.com/buildroot/buildroot/blame/master/package/qt5/qt5base/qt5base.mk#L280
>
> This patch removes all variables concerning pkgconf paths. At the time
> the qt5base package was introduced the pkgconf wrapper did not exist.
> Today these variables are not necessary anymore.
>
> Fixes
> http://autobuild.buildroot.net/results/061/06159500c27026d56a772fafbb0d956c72dd4e6c/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: Removed PKG_CONFIG_* variables (Thomas)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-08-05 10:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 18:09 [Buildroot] [PATCH v2 1/1] package/qt5/qt5base: fix PKG_CONFIG_LIBDIR Bernd Kuhls
2018-08-05 10:55 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180805125539.7bff50c7@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox