From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mmc-utils: Rely on our own _FORTIFY_SOURCE
Date: Wed, 8 Aug 2018 15:17:09 +0200 [thread overview]
Message-ID: <20180808151709.2f35030c@windsurf> (raw)
In-Reply-To: <48287dd12fcef0440cc49ff86343867d6cb8429e.1533656185.git.jan.kundrat@cesnet.cz>
Hello,
On Tue, 7 Aug 2018 17:32:51 +0200, Jan Kundr?t wrote:
> Upstream always forced _FORTIFY_SOURCE=2. At first, I tried changing
> their flags to undefine that macro first, but that did not work well.
> This patch ensures that the package always respects our toolchain
> settings, even in cases where we are not fortifying the build.
>
> This fixes a build failure where the mmc-utils package failed to build
> with, e.g., BR2_FORTIFY_SOURCE_1:
>
> <command-line>:0:0: error: "_FORTIFY_SOURCE" redefined [-Werror]
> <command-line>:0:0: note: this is the location of the previous definition
>
> Signed-off-by: Jan Kundr?t <jan.kundrat@cesnet.cz>
Is this fixing a build issue reported by the autobuilders ? Or only
with hardening options ? Your commit log is not very verbose in details
about the configuration/condition under which the build failure happens.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-08 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 15:32 [Buildroot] [PATCH] mmc-utils: Rely on our own _FORTIFY_SOURCE Jan Kundrát
2018-08-08 7:25 ` Jan Kundrát
2018-08-08 13:17 ` Thomas Petazzoni [this message]
2018-08-10 2:56 ` Matthew Weber
2018-10-25 18:03 ` Jan Kundrát
2018-10-29 13:15 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808151709.2f35030c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox