From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ncmpc: fix build with some old toolchains
Date: Sun, 12 Aug 2018 16:01:44 +0200 [thread overview]
Message-ID: <20180812160144.0d172d2a@windsurf> (raw)
In-Reply-To: <CAPi7W82Mof=7vNE8quasJNiRd8Yt8YTaRsdTXfZWOnQT0tFURg@mail.gmail.com>
Hello,
On Sun, 12 Aug 2018 15:52:07 +0200, Fabrice Fontaine wrote:
> > To be honest, I don't have enough C++ knowledge to figure out if this
> > is the right fix, but I've applied to master anyway. Please submit
> > upstream to get a proper review. Thanks!
> >
> I sent it upstream (https://github.com/MusicPlayerDaemon/ncmpc/pull/29) but
> the PR has been closed :-/
Considering upstream's reaction, perhaps we should drop the patch, and
add the appropriate BR2_TOOLCHAIN_HAS_GCC_AT_LEAST_... dependency ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-12 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 7:45 [Buildroot] [PATCH 1/1] ncmpc: fix build with some old toolchains Fabrice Fontaine
2018-08-12 12:32 ` Thomas Petazzoni
2018-08-12 13:52 ` Fabrice Fontaine
2018-08-12 14:01 ` Thomas Petazzoni [this message]
2018-08-12 14:15 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180812160144.0d172d2a@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox