From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 14 Aug 2018 16:12:00 +0200 Subject: [Buildroot] [PATCH] openresolv: new package In-Reply-To: <1533648586-60818-1-git-send-email-matthew.weber@rockwellcollins.com> References: <1533648586-60818-1-git-send-email-matthew.weber@rockwellcollins.com> Message-ID: <20180814161200.08d4a984@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Matt, On Tue, 7 Aug 2018 08:29:46 -0500, Matt Weber wrote: > package/Config.in | 1 + > package/openresolv/Config.in | 13 +++++++++++++ > package/openresolv/openresolv.hash | 3 +++ > package/openresolv/openresolv.mk | 12 ++++++++++++ > 4 files changed, 29 insertions(+) Entry in DEVELOPERS file is missing. > diff --git a/package/Config.in b/package/Config.in > index f5a1749..2ad6687 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1843,6 +1843,7 @@ endif > source "package/open-plc-utils/Config.in" > source "package/openntpd/Config.in" > source "package/openobex/Config.in" > + source "package/openresolv/Config.in" > source "package/openssh/Config.in" > source "package/openswan/Config.in" > source "package/openvpn/Config.in" > diff --git a/package/openresolv/Config.in b/package/openresolv/Config.in > new file mode 100644 > index 0000000..3eb736f > --- /dev/null > +++ b/package/openresolv/Config.in > @@ -0,0 +1,13 @@ > +comment "openresolv needs a bash shell" > + depends on !BR2_SYSTEM_BIN_SH_BASH Are you sure it needs a bash shell ? Indeed in https://github.com/rsmarples/openresolv, the #1 argument for resolvconf compared to its Debian variant is: "" Works with POSIX shell and userland "" > $(eval $(autotools-package)) This package is not using the autotools. The configure script is not generated by autoconf, the Makefile is not generated by automake. So, generic-package should be used, and not autotools-package. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com