Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] New <pkg>-update-last-config-fragment target in pkg-kconfig.mk
Date: Tue, 14 Aug 2018 16:27:05 +0200	[thread overview]
Message-ID: <20180814162705.505476fe@windsurf> (raw)
In-Reply-To: <20180731154948.GB8537@scaer>

Hello,

Adding Arnout and Peter in Cc, in case they want to give their opinion
on the patch series.

On Tue, 31 Jul 2018 17:49:48 +0200, Yann E. MORIN wrote:

> I would just suggest that we do not add any new rule, but trying to
> update the defconfig when there are fragments would fail as it currently
> does, but also would display the delta if there is one. I.e.:
> 
>     $ make linux-menuconfig
>     [change stuff]
>     $ make linux-update-defconfig
>     Unable to perform linux-update-defconfig when fragment files are set
>     Configuration changes that you want to propagate to one of the fragments:
>     -CONFIG_FOO=y
>     +# CONFIG_BAR is unset
>     linux/linux.mk:511: recipe for target 'linux-update-defconfig' failed
>     make[1]: *** [linux-update-defconfig] Error 1

I think we could do that in *addition* to having a new rule. Indeed,
when you know what you're doing, having to run something that doesn't
make sense ("make linux-update-defconfig") and which causes a failure
is a bit silly. I'd rather run "make linux-diff-config" (or whatever
name we chose).

Marcel, do you think you could rework your patch series to go in the
direction of showing a diff rather than arbitrarily adjusting the last
fragment ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-08-14 14:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 15:51 [Buildroot] [PATCH 0/3] Buildroot: Target to update config fragments in kconfig based packages Marcel Patzlaff
2018-07-30 15:51 ` [Buildroot] [PATCH 1/3] Support script for defconfig comparison Marcel Patzlaff
2018-07-30 15:51 ` [Buildroot] [PATCH 2/3] Refactoring of pkg-kconfig.mk to increase re-usability Marcel Patzlaff
2018-07-30 15:51 ` [Buildroot] [PATCH 3/3] New <pkg>-update-last-config-fragment target in pkg-kconfig.mk Marcel Patzlaff
2018-07-30 21:46   ` Thomas Petazzoni
2018-07-31  7:44     ` [Buildroot] Antwort: " Marcel Patzlaff
2018-07-31  7:53       ` [Buildroot] " Thomas Petazzoni
2018-07-31  8:43         ` [Buildroot] Antwort: " Marcel Patzlaff
2018-07-31 15:49     ` [Buildroot] " Yann E. MORIN
2018-08-14 14:27       ` Thomas Petazzoni [this message]
2018-08-14 15:29         ` Yann E. MORIN
2018-08-14 23:20         ` Arnout Vandecappelle
2018-08-15 12:04           ` Thomas Petazzoni
2018-08-15 16:16             ` Yann E. MORIN
2018-08-15 17:35               ` Thomas Petazzoni
2018-08-15 20:29                 ` Yann E. MORIN
2018-08-15 22:15                   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180814162705.505476fe@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox