From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/Next v2] package/proftpd: add BR2_PACKAGE_PROFTPD_MOD_SFTP
Date: Tue, 14 Aug 2018 22:22:30 +0200 [thread overview]
Message-ID: <20180814222230.1c53a863@windsurf> (raw)
In-Reply-To: <1534270525-48448-1-git-send-email-matthew.weber@rockwellcollins.com>
Hello,
On Tue, 14 Aug 2018 13:15:25 -0500, Matt Weber wrote:
> +#Append all required modules in PROFTPD_MODULES variable
> +#Use 'space' seperator for more than one module
> +#e.g. PROFTPD_MODULES += mod_readme mod_ifsession
This comment really wasn't necessary, that's how we do things
everywhere in Buildroot, for all variables.
> ifeq ($(BR2_PACKAGE_PROFTPD_MOD_REWRITE),y)
> -PROFTPD_CONF_OPTS += --with-modules=mod_rewrite
> +PROFTPD_MODULES = mod_rewrite
I changed the "=" here to a "+=" to avoid potential mistakes in the
future.
Applied to next with those changes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-08-14 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 18:15 [Buildroot] [PATCH/Next v2] package/proftpd: add BR2_PACKAGE_PROFTPD_MOD_SFTP Matt Weber
2018-08-14 20:22 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814222230.1c53a863@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox