From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/pkg-golang: fix illegal variable reference
Date: Wed, 15 Aug 2018 14:36:50 +0200 [thread overview]
Message-ID: <20180815143650.794906c2@windsurf> (raw)
In-Reply-To: <20180815071609.6722-1-mirza.krak@northern.tech>
Hello,
On Wed, 15 Aug 2018 09:16:09 +0200, Mirza Krak wrote:
> References to variables inside $(eval) blocks must be with a double
> dollar sign, otherwise we end up with unintuitive and undesired behavior
> according to the description in pkg-generic.mk
>
> Signed-off-by: Mirza Krak <mirza.krak@northern.tech>
> ---
> package/pkg-golang.mk | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
I hesitated a bit between applying to master or next. It is a bug fix,
so it should be master. But it doesn't cause any visible issue for now,
so maybe not master. In the end, since the fix is pretty trivial, I
applied to master.
However, I rewrote the commit log to provide (I believe) a better
explanation of the issue being fixed.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-15 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 7:16 [Buildroot] [PATCH 1/1] package/pkg-golang: fix illegal variable reference Mirza Krak
2018-08-15 12:36 ` Thomas Petazzoni [this message]
2018-08-15 12:48 ` Mirza Krak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815143650.794906c2@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox