From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] Analysis of build results for 2018-08-17
Date: Sun, 19 Aug 2018 21:26:52 +0200 [thread overview]
Message-ID: <20180819212652.01b7b9c9@windsurf> (raw)
In-Reply-To: <871saunpwq.fsf@dell.be.48ers.dk>
Hello,
On Sun, 19 Aug 2018 20:59:33 +0200, Peter Korsgaard wrote:
> > This is due to a Qt method that has been removed in Qt 5.11. It can be
> > fixed by applying
> > https://src.fedoraproject.org/rpms/python-qt5/c/47fb7fdc5d16582772f9c3fc8a6a674a41a7f605?branch=master,
> > but we need to find a way to make this conditional on Qt 5.11 (indeed
> > with Qt 5.6, this should be preserved).
>
> I believe this can be done by checking QT_VERSION:
>
> https://doc.qt.io/qt-5/qtglobal.html#QT_VERSION
The SIP stuff that is used by PyQt to generate the binding also has a
mechanism for conditional compilation depending on the Qt version.
However, as explained in the patch I submitted to fix this issue [1],
in the upstream PyQt5, they decided to drop entirely the support for
this waitForEvents() method, even if PyQt5 is built against an older
version of Qt than 5.11 (PyQt5 is full of conditionals depending on the
Qt version, but they decided to not use that for waitForEvents). My
patch follows what upstream did.
Best regards,
Thomas
[1] http://patchwork.ozlabs.org/patch/959269/
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-08-19 19:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 6:00 [Buildroot] [autobuild.buildroot.net] Build results for 2018-08-17 Thomas Petazzoni
2018-08-18 19:56 ` [Buildroot] Analysis of build " Thomas Petazzoni
2018-08-18 20:40 ` Chris Packham
2018-08-18 20:56 ` Thomas Petazzoni
2018-08-18 22:37 ` Peter Seiderer
2018-08-19 18:59 ` Peter Korsgaard
2018-08-19 19:26 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180819212652.01b7b9c9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox