From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Seiderer <ps.report@gmx.net>
Date: Sun, 19 Aug 2018 21:49:17 +0200
Subject: [Buildroot] [RFC v3 2/4] meson: change from global to per
 package cross-compilation.conf
In-Reply-To: <20180819191511.3c38bb60@gmx.net>
References: <20180719204355.10465-1-ps.report@gmx.net>
 <20180719204355.10465-2-ps.report@gmx.net>
 <20180816135745.71ed73f2@windsurf>
 <20180819011512.11fad995@gmx.net>
 <20180819152206.7b15fce9@windsurf>
 <20180819191511.3c38bb60@gmx.net>
Message-ID: <20180819214917.67c960a3@gmx.net>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hello Thomas,

On Sun, 19 Aug 2018 19:15:11 +0200, Peter Seiderer <ps.report@gmx.net> wrote:

> Hello Thomas,
> 
> 
> On Sun, 19 Aug 2018 15:22:06 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> 
> > Hello,
> > 
> > On Sun, 19 Aug 2018 01:15:12 +0200, Peter Seiderer wrote:
> >   
> > > The CFLAGS are ignored, e.g. with 'LIBDRM_CONF_ENV += CFLAGS=-DAO_NO_SPARC_V9' in package/libdrm/libdrm.mk:
> > > 
> > > 	$ make libdrm V=1    
> > 
> > It seems weird, no? It is documented to be working, and even at runtime
> > it tells you "I am going to use those additional CFLAGS". Isn't this a
> > bug or a misuse of meson from us ?
> >   
> 
> Bug or feature of the cross-compilation.conf usage? Will take a look at
> the meson sources....

Seems to be intentional, see mesonbuild/backend/backends.py#L542 ([1]):

        if not target.is_cross:
            # Compile args added from the env: CFLAGS/CXXFLAGS, etc. We want these
            # to override all the defaults, but not the per-target compile args.
commands += self.environment.coredata.get_external_args(compiler.get_language())

With the 'if not target.is_cross' added with this commit [2] fixing [3] which
suggests adding CROSS_*FLAGS...

Regards,
Peter

[1] https://github.com/mesonbuild/meson/blob/master/mesonbuild/backend/backends.py#L542
[2] https://github.com/mesonbuild/meson/commit/b595cda4ed0ca699da3052a6bd30ba7d1dae1124
[3] https://github.com/mesonbuild/meson/issues/1772

> 
> Regards,
> Peter
> 
> > I would really prefer to understand what is going on here instead of
> > having to generate per-package .conf files.
> > 
> > Thanks!
> > 
> > Thomas  
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot