Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/2] boost: context needs thread if gcc <= 4.6
Date: Tue, 21 Aug 2018 11:27:24 +0200	[thread overview]
Message-ID: <20180821112724.3835f7ae@windsurf> (raw)
In-Reply-To: <20180820221257.1553-1-fontaine.fabrice@gmail.com>

Hello,

On Tue, 21 Aug 2018 00:12:56 +0200, Fabrice Fontaine wrote:
> mutex is available on gcc 4.7.x, the issue is that boost does not
> correctly detect it because -std=c++11 is missing.

Where did you get the information that mutex is available since gcc
4.7 ? Is it by testing gcc 4.6 and 4.7 ?

I couldn't get this information by looking at
https://gcc.gnu.org/projects/cxx-status.html#cxx11.

Also, I am wondering if the two patches should really be separate.
Aren't they in fact both intimately related, where std::mutex will only
be visible in gcc >= 4.7 if std=c++11 is passed ?

To me, they are basically one single patch:

 - Below gcc 4.7, we don't have std::mutex, so boost-thread must be used
 - Above gcc 4.7, we have std::mutex, but we need to pass std=c++11 for
   std::mutex to be visible/usable

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-08-21  9:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 22:12 [Buildroot] [PATCH v2, 1/2] boost: context needs thread if gcc <= 4.6 Fabrice Fontaine
2018-08-20 22:12 ` [Buildroot] [PATCH v2,2/2] boost: context needs C++11 Fabrice Fontaine
2018-08-21  9:27 ` Thomas Petazzoni [this message]
2018-08-21 18:26   ` [Buildroot] [PATCH v2, 1/2] boost: context needs thread if gcc <= 4.6 Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180821112724.3835f7ae@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox