From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next 1/4] lzo: build shared library for the host
Date: Wed, 22 Aug 2018 00:07:48 +0200 [thread overview]
Message-ID: <20180821220748.GS15347@scaer> (raw)
In-Reply-To: <20180821215954.11971-2-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2018-08-21 23:59 +0200, Thomas Petazzoni spake thusly:
> By default, the lzo package builds and installs only a static
> library. For the target variant, we pass the appropriate
> ENABLE_STATIC/ENABLE_SHARED options, but not for the host package, and
> therefore a static lzo library gets installed.
>
> However, on the host, our policy is to build shared libraries and not
> static libraries, as visible in the default configure options passed
> to host package in pkg-autotools.mk (--enable-shared
> --disable-static). Let's do the same with lzo.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/lzo/lzo.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/lzo/lzo.mk b/package/lzo/lzo.mk
> index 27ca459acf..0ead92725a 100644
> --- a/package/lzo/lzo.mk
> +++ b/package/lzo/lzo.mk
> @@ -23,5 +23,7 @@ else
> LZO_CONF_OPTS += -DENABLE_STATIC=OFF
> endif
>
> +HOST_LZO_CONF_OPTS += -DENABLE_SHARED=ON -DENABLE_STATIC=OFF
> +
> $(eval $(cmake-package))
> $(eval $(host-cmake-package))
> --
> 2.14.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-08-21 22:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 21:59 [Buildroot] [PATCH next 0/4] btrfs-progs related improvements Thomas Petazzoni
2018-08-21 21:59 ` [Buildroot] [PATCH next 1/4] lzo: build shared library for the host Thomas Petazzoni
2018-08-21 22:07 ` Yann E. MORIN [this message]
2018-08-21 21:59 ` [Buildroot] [PATCH next 2/4] e2fsprogs: " Thomas Petazzoni
2018-08-21 22:11 ` Yann E. MORIN
2018-08-22 11:46 ` Thomas Petazzoni
2018-08-21 21:59 ` [Buildroot] [PATCH next 3/4] btrfs-progs: drop dependency on e2fsprogs by not building btrfs-convert Thomas Petazzoni
2018-08-21 22:15 ` Yann E. MORIN
2018-08-21 21:59 ` [Buildroot] [PATCH next 4/4] btrfs-progs: make e2fsprogs an optional dependency Thomas Petazzoni
2018-08-21 22:18 ` Yann E. MORIN
2018-08-21 22:08 ` [Buildroot] [PATCH next 0/4] btrfs-progs related improvements Yann E. MORIN
2018-08-22 11:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821220748.GS15347@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox