From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Thu, 23 Aug 2018 12:20:29 +0200 Subject: [Buildroot] [PATCH] package/mesa3d: vulkan with x11 needs dri3 In-Reply-To: <20180823121152.30d51975@windsurf> References: <20180823090827.4003-1-yann.morin.1998@free.fr> <20180823121152.30d51975@windsurf> Message-ID: <20180823102029.GE9365@scaer> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Thomas, All, On 2018-08-23 12:11 +0200, Thomas Petazzoni spake thusly: > On Thu, 23 Aug 2018 11:08:27 +0200, Yann E. MORIN wrote: > > Fixes: > > http://autobuild.buildroot.org/results/356/35653fc6f57dc169a8aae6baedb1acd1049b50ec/ > > > > Signed-off-by: "Yann E. MORIN" > > Cc: Bernd Kuhls > > Cc: Romain Naour > > I was about to apply, but something caught my eye. Dang... > > -ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),) > > +ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER)$(BR2_PACKAGE_MESA3D_VULKAN_DRIVER),) > > MESA3D_CONF_OPTS += \ > > --without-dri-drivers --disable-dri3 > > This change makes sure that when BR2_PACKAGE_MESA3D_VULKAN_DRIVER=y, we > no longer pass --disable-dri3, because we indeed what DRI3 to be > enabled for the Intel Vulkan driver to build. > > However, as a side-effect, it is also going to cause > --without-dri-drivers to no longer be passed, even though we are > possibly not building any DRI driver (ie BR2_PACKAGE_MESA3D_DRI_DRIVER > may be disabled). Hmm... > Doesn't this requires a bit more rework to be clean ? Yes, I'll have a further look by the end of the day. I've marked it as Changes Requested. To be hnest, the whole of mesa3d may need a complete overhaul I think. Theree dubious constructs here and there, like: config BR2_PACKAGE_MESA3D_DRI_DRIVER bool select BR2_PACKAGE_MESA3D_DRIVER select BR2_PACKAGE_XLIB_LIBXSHMFENCE if \ (BR2_PACKAGE_XORG7 && BR2_TOOLCHAIN_HAS_SYNC_4) So now I wonder if we shouldn't have something akin to this for Vulkan. Really, mesa3d has become quite a nest of snakes. It's hard to follow and understand the dependencies between each config options... > Perhaps we need to separate the handling of enable-dri3/disable-dri3 > from the with-dri-drivers/without-dri-drivers ? Probably, yes... > Side question: the error message "ANV Vulkan driver requires DRI3 when > built with X11" implies that the Intel Vulkan driver can be built > without X11, while in Buildroot we require X11 to build the Intel > Vulkan driver. Note: this is unrelated to the build failure, and could > be improved as a separate patch, but is definitely not mandatory to > fix. It's just something I noticed while looking at this issue. I'll have a look later today. Thanks for the feedback. :-) Regards, Yann E. MORIN. > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'