Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/6] libb64: Fix integer overflow and uninitialized C++ objects.
Date: Thu, 23 Aug 2018 13:43:01 +0200	[thread overview]
Message-ID: <20180823134301.3923e2b7@windsurf> (raw)
In-Reply-To: <20180823103930.5112-1-mikael@robomagi.com>

Hello,

On Thu, 23 Aug 2018 12:39:30 +0200, Mikael Eliasson wrote:
> Signed-off-by: Mikael Eliasson <mikael@robomagi.com>

Thanks Mikael for this patch. First of all, why is it PATCH 6/6 ? We
did not receive anything else but this sixth patch. Did you had other
patches in your series, or is this a mistake ?

Also, could you provide some explanation in the commit log as to why we
want those fixes ? Are there fixing security issues ? Runtime bugs ? A
bit of context/explanation would be good to have.

Also, since libb64 is maintained with Git (git clone
https://git.code.sf.net/p/libb64/git libb64-git), could you use
Git-formatted patches, for both patches (and therefore have both of
them in package/, rather than download one from Debian, and have one in
package/) ?

Have these patches been submitted upstream ?

Thanks!

Thomas Petazzoni
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-08-23 11:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23 10:39 [Buildroot] [PATCH 6/6] libb64: Fix integer overflow and uninitialized C++ objects Mikael Eliasson
2018-08-23 11:43 ` Thomas Petazzoni [this message]
2018-08-23 14:03   ` Mikael Eliasson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180823134301.3923e2b7@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox