Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] rauc: add patch to make it build with Linux < 3.0
Date: Fri, 24 Aug 2018 23:18:24 +0200	[thread overview]
Message-ID: <20180824231824.228ae0e5@windsurf> (raw)
In-Reply-To: <20180824210956.GQ9365@scaer>

Hello,

On Fri, 24 Aug 2018 23:09:56 +0200, Yann E. MORIN wrote:

> On 2018-08-24 14:35 +0200, Thomas Petazzoni spake thusly:
> > This commit adds a patch to RAUC that makes the eMMC boot partition
> > support optional. This allows RAUC to build successfully on systems
> > using Linux < 3.0.  
> 
> In your haste in proving me wrong with this emmc in rauc issue, you
> forgot a very important and crucial point: you are touching configure.ac
> with this patch, so you need RAUC_AUTORECONF = YES . ;-)

Gaah, indeed! In fact, I only tested the patch outside of the context
of Buildroot, forcing ac_cv_header_linux_mmc_ioctl_h=no to test the
Linux < 3.0 case.

> Sarcasm aside, with the above fixed:
> 
>     Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>     Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> To test this, apart the autoreconf change, I also removed that
> looked-for header from my system, to be sure to have the test fail.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-08-24 21:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24 12:35 [Buildroot] [PATCH] rauc: add patch to make it build with Linux < 3.0 Thomas Petazzoni
2018-08-24 21:09 ` Yann E. MORIN
2018-08-24 21:18   ` Thomas Petazzoni [this message]
2018-08-24 21:50 ` Thomas Petazzoni
2018-08-26 21:13 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180824231824.228ae0e5@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox