Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] arch: add support for RISC-V 64-bit (riscv64) architecture
Date: Tue, 4 Sep 2018 13:24:07 +0200	[thread overview]
Message-ID: <20180904132407.08be2dc1@windsurf> (raw)
In-Reply-To: <6c81203c-261c-8525-1fda-5da1074db56e@embecosm.com>

Hello,

On Tue, 4 Sep 2018 11:03:22 +0100, Mark Corbin wrote:

> There is a name clash with using GCC_TARGET_* - some of these names are
> already used in packages/gcc/gcc.mk.
> 
> GCC_TARGET_FPU = $(call qstrip,$(BR2_GCC_TARGET_FPU))

Well, just get rid of this line, since it's now going to be in
arch/arch.mk.

> ifneq ($(GCC_TARGET_FPU),)
> HOST_GCC_COMMON_CONF_OPTS += --with-fpu=$(GCC_TARGET_FPU)
> endif
> 
> GCC_TARGET_FLOAT_ABI = $(call qstrip,$(BR2_GCC_TARGET_FLOAT_ABI))

Ditto.

> ifneq ($(GCC_TARGET_FLOAT_ABI),)
> HOST_GCC_COMMON_CONF_OPTS += --with-float=$(GCC_TARGET_FLOAT_ABI)
> endif
> 
> GCC_TARGET_MODE = $(call qstrip,$(BR2_GCC_TARGET_MODE))

Ditto.

> ifneq ($(GCC_TARGET_MODE),)
> HOST_GCC_COMMON_CONF_OPTS += --with-mode=$(GCC_TARGET_MODE)
> endif
> 
> Anybody have any thoughts for a new prefix for either set of variables?

Not needed: the whole idea of the change is to move those line setting
GCC_TARGET_* variables from package/gcc/ to arch/arch.mk.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-09-04 11:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31  9:11 [Buildroot] [PATCH 1/1] arch: add support for RISC-V 64-bit (riscv64) architecture Mark Corbin
2018-09-02 19:40 ` Thomas Petazzoni
2018-09-03 11:26   ` Mark Corbin
2018-09-03 22:20     ` Arnout Vandecappelle
2018-09-04  7:49       ` Thomas Petazzoni
2018-09-04  8:51         ` Arnout Vandecappelle
2018-09-04 14:44           ` Mark Corbin
2018-09-04 14:50         ` Mark Corbin
2018-09-04 10:03   ` Mark Corbin
2018-09-04 11:24     ` Thomas Petazzoni [this message]
2018-09-03 23:00 ` Arnout Vandecappelle
2018-09-04 13:10   ` Mark Corbin
2018-09-04 21:03     ` Arnout Vandecappelle
2018-09-05 10:09       ` Mark Corbin
2018-09-07 19:26         ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180904132407.08be2dc1@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox