From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 1/3] Makefile: add tainting support
Date: Thu, 6 Sep 2018 09:44:51 +0200 [thread overview]
Message-ID: <20180906094451.44df8776@windsurf> (raw)
In-Reply-To: <1536186133-9933-2-git-send-email-angelo.compagnucci@gmail.com>
Hello,
On Thu, 6 Sep 2018 00:22:11 +0200, Angelo Compagnucci wrote:
> Packages who harms the build reproducibility or licensing can declare
> FOO_TAINTS variable. If a package taints the build it will be added
> to a list of tainting packages. The build ends with a warning if the
> tainting packages list is not empty. Moreover, legal info will show
> a warning in presence of a tainting package.
>
> Tainting of host packages is not supported right now.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Why two SoBs ? Just one matching the From: is good enough.
> +ifdef $(2)_TAINTS
> +ifeq ($$($$($(2)_KCONFIG_VAR)),y)
> +BR2_TAINTED_BY+=$$($(2)_RAWNAME)
Spaces around +=
No need to resend just for that. Just explain why you have two SoB, if
I can keep just one, I can fix that up when applying.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-06 7:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 22:22 [Buildroot] [PATCH v5 0/3] Add tainting support to buildroot Angelo Compagnucci
2018-09-05 22:22 ` [Buildroot] [PATCH v5 1/3] Makefile: add tainting support Angelo Compagnucci
2018-09-06 7:44 ` Thomas Petazzoni [this message]
2018-09-06 7:46 ` Angelo Compagnucci
2018-09-05 22:22 ` [Buildroot] [PATCH v5 2/3] docs/manual: adding infos about tainting Angelo Compagnucci
2018-09-09 8:00 ` Yann E. MORIN
2018-09-05 22:22 ` [Buildroot] [PATCH v5 3/3] package/nodejs: taint the build on external modules Angelo Compagnucci
2018-09-09 7:49 ` Yann E. MORIN
2018-09-09 12:17 ` Angelo Compagnucci
2018-09-09 13:01 ` Yann E. MORIN
2018-09-09 13:29 ` Angelo Compagnucci
2018-09-06 7:42 ` [Buildroot] [PATCH v5 0/3] Add tainting support to buildroot Thomas Petazzoni
2018-09-09 7:36 ` Yann E. MORIN
2018-09-09 12:10 ` Thomas Petazzoni
2018-09-09 12:25 ` Angelo Compagnucci
2018-09-09 13:33 ` Yann E. MORIN
2018-09-09 13:44 ` Angelo Compagnucci
2018-09-09 14:20 ` Yann E. MORIN
2018-09-09 16:58 ` Angelo Compagnucci
2018-09-09 18:55 ` Yann E. MORIN
2018-09-09 20:18 ` Angelo Compagnucci
2018-09-10 7:50 ` Angelo Compagnucci
2018-09-10 15:00 ` Yann E. MORIN
2018-09-10 15:37 ` Yann E. MORIN
2018-09-10 17:10 ` Angelo Compagnucci
2018-09-10 18:07 ` Yann E. MORIN
2018-09-10 19:17 ` Angelo Compagnucci
2018-09-10 19:43 ` Yann E. MORIN
2018-09-10 20:03 ` Angelo Compagnucci
2018-09-10 20:26 ` Yann E. MORIN
2018-09-11 6:20 ` Angelo Compagnucci
2018-09-10 19:37 ` Thomas Petazzoni
2018-09-10 19:55 ` Angelo Compagnucci
2018-09-10 20:37 ` Yann E. MORIN
2018-09-09 13:27 ` Yann E. MORIN
2018-11-01 12:14 ` Arnout Vandecappelle
2018-11-01 12:25 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906094451.44df8776@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox