From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libminiupnpc: fix hash for license file
Date: Sat, 8 Sep 2018 21:48:47 +0200 [thread overview]
Message-ID: <20180908214847.27eb3a59@windsurf.home> (raw)
In-Reply-To: <CALFsTFWp749gJPo4U-fODmquKzdwQtd=CM8d7MishAWLSsy2Tw@mail.gmail.com>
Hello,
On Sat, 8 Sep 2018 22:43:12 +0300, Asaf Kahlon wrote:
> They just replaced the year 2015 with 2016...
This should be mentioned in the commit log, so that we know that
someone has verified what the changes were. That's the whole point of
having hashes for license files: detecting when the license file
contents are changed. So if we just blindly update the hash, it
completely defeats the purpose of having those hashes.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-09-08 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 17:59 [Buildroot] [PATCH 1/1] libminiupnpc: fix hash for license file Asaf Kahlon
2018-09-08 19:36 ` Thomas Petazzoni
2018-09-08 19:43 ` Asaf Kahlon
2018-09-08 19:48 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180908214847.27eb3a59@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox