From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] gst1-plugins-good: add option for qmlgl plugin (qt5 plugin)
Date: Sat, 8 Sep 2018 22:07:52 +0200 [thread overview]
Message-ID: <20180908220752.4254ec4c@windsurf.home> (raw)
In-Reply-To: <1535958840-4452-1-git-send-email-inigohuguet@fanamoel.com>
Hello I?igo,
On Mon, 3 Sep 2018 09:14:00 +0200, I?igo Huguet wrote:
> gst1-plugins-good is built with --disable-qt option, so qmlgl plugin
> is disabled. Added option to enable it, allowing to use elements
> qmlglsrc and qmlglsink.
>
> Signed-off-by: I?igo Huguet <inigohuguet@fanamoel.com>
Thanks for this new iteration!
> diff --git a/package/gstreamer1/gst1-plugins-good/0001-configure-fix-qt-qpa-detection.patch b/package/gstreamer1/gst1-plugins-good/0001-configure-fix-qt-qpa-detection.patch
> new file mode 100644
> index 0000000..d755354
> --- /dev/null
> +++ b/package/gstreamer1/gst1-plugins-good/0001-configure-fix-qt-qpa-detection.patch
> @@ -0,0 +1,14 @@
> +configure: fix QT QPA detection
> +
> +Signed-off-by: I?igo Huguet <inigohuguet@fanamoel.com>
> +
> +--- gst1-plugins-good-1.14.2/configure_orig 2018-08-15 19:42:48.065311007 +0200
> ++++ gst1-plugins-good-1.14.2/configure 2018-08-15 19:42:58.665528543 +0200
> +@@ -35924,7 +35924,7 @@
> + else
> + HAVE_QT="yes"
> + HAVE_QT_WINDOWING="no"
> +- QT_VERSION="`$PKG_CONFIG --define-prefix --modversion Qt5Core`"
> ++ QT_VERSION="`$PKG_CONFIG --modversion Qt5Core`"
I think patching GStreamer is not the right approach here. Could you
instead apply http://patchwork.ozlabs.org/patch/967653/, which updates
our pkgconf package to use a newer version that supports the
--define-prefix option ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-08 20:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 9:13 [Buildroot] [PATCH 1/1] Add option to the gst1-plugins-bad package to enable/disable the qt plugin Glenn Coombs
2017-07-21 9:22 ` Thomas Petazzoni
2017-07-24 6:19 ` Glenn Coombs
2017-08-23 12:32 ` Thomas Petazzoni
2018-07-23 8:55 ` [Buildroot] [PATCH 1/1] gst1-plugins-good: add option for qmlgl plugin (qt5 plugin) Iñigo Huguet
2018-07-23 11:10 ` Iñigo Huguet
2018-07-28 22:22 ` Arnout Vandecappelle
2018-08-02 11:11 ` Iñigo Huguet
2018-08-14 14:22 ` Thomas Petazzoni
2018-08-15 19:02 ` Peter Seiderer
2018-09-03 7:14 ` [Buildroot] [PATCH v3] " Iñigo Huguet
2018-09-03 11:59 ` Martin Kepplinger
2018-09-08 20:07 ` Thomas Petazzoni [this message]
2018-09-12 6:46 ` Iñigo Huguet
2018-09-12 7:38 ` Thomas Petazzoni
2018-09-18 10:58 ` [Buildroot] [PATCH v4] " Iñigo Huguet
2019-04-07 13:36 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180908220752.4254ec4c@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox