Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] motion: fix build failure due to missing drmGetVersion() and drmFreeVersion()
Date: Mon, 10 Sep 2018 09:21:22 +0200	[thread overview]
Message-ID: <20180910092122.188e26ed@windsurf.home> (raw)
In-Reply-To: <20180909193343.117159-1-giulio.benetti@micronovasrl.com>

Hello,

On Sun,  9 Sep 2018 21:33:43 +0200, Giulio Benetti wrote:
> During static linking -ldrm is listed too early respect -lavutil.
> This cause build failure.
> 
> Append extra -ldrm at the tail of $(LIBS) list.
> 
> Fixes:
> http://autobuild.buildroot.net/results/395/395be1a9cab824b82ef34c2ebd84d54243029b33//
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

This fix should not be needed: the configure.ac script is using
pkg-config to detect ffmpeg libraries, and pkg-config should return the
right libraries.

In addition, your patch will badly break the build: ffmpeg is only an
optional dependency of motion, and DRM support in ffmpeg itself is
optional, so the patch is clearly wrong.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-09-10  7:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-09 19:33 [Buildroot] [PATCH] motion: fix build failure due to missing drmGetVersion() and drmFreeVersion() Giulio Benetti
2018-09-10  6:35 ` Giulio Benetti
2018-09-10  7:21 ` Thomas Petazzoni [this message]
2018-09-11 13:27   ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180910092122.188e26ed@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox